Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] ObservableGroupedSource - improvements #26956

Merged

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jan 4, 2025

Description of Change

I've made some changes so that the ObservableGroupedSource resembles ObservableItemsSource. It fixes the crash #25514 which I've observed on both CV and CV2

Issues Fixed

Fixes #25514

Before After
Screen.Recording.2025-01-04.at.12.21.51.mov
Screen.Recording.2025-01-04.at.01.33.26.mov

@rmarinho what do you think?

@kubaflo kubaflo requested a review from a team as a code owner January 4, 2025 11:49
@kubaflo kubaflo requested review from mattleibow and PureWeen January 4, 2025 11:49
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 4, 2025
@kubaflo kubaflo requested a review from rmarinho January 4, 2025 11:51
@PureWeen
Copy link
Member

PureWeen commented Jan 6, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for CV are failing

@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 7, 2025

Hi @rmarinho! Could you please /azp again?

@rmarinho
Copy link
Member

rmarinho commented Jan 7, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen requested a review from Copilot January 8, 2025 18:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/Controls/tests/TestCases.HostApp/Issues/Issue25514.xaml: Language not supported
@jfversluis jfversluis added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Jan 9, 2025
@rmarinho rmarinho self-requested a review January 9, 2025 12:52
@rmarinho rmarinho merged commit 1b2f4f1 into dotnet:main Jan 9, 2025
102 of 104 checks passed
@cvchris
Copy link

cvchris commented Jan 15, 2025

Dear @rmarinho, will this fix be included in an 8.x.x release? We are currently facing an issue that should be resolved with this PR and we have not upgraded to .NET 9
Thanks in advance!

@rmarinho
Copy link
Member

@cvchris nop, this will be in a net9 service release only.

@nguyenhh
Copy link

Which service release will this fix be in? I just installed 9.0.200-preview.0.24575.35 but it is not working. Thanks!

@MartyIX
Copy link
Contributor

MartyIX commented Jan 16, 2025

Which service release will this fix be in? I just installed 9.0.200-preview.0.24575.35 but it is not working. Thanks!

In .NET MAUI 9.0.30 (https://github.com/dotnet/maui/releases/tag/9.0.30), this PR is mentioned as a part of the release.

9.0.200-preview.0.24575.35 is a .NET SDK version, not a version of .NET MAUI. So you can either use .NET MAUI as nugets (you can do it right now) or wait for a new release of Visual Studio Preview (AFAIK).

@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution
Projects
None yet
7 participants