-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] ObservableGroupedSource - improvements #26956
[iOS] ObservableGroupedSource - improvements #26956
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests for CV are failing
Hi @rmarinho! Could you please /azp again? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue25514.xaml: Language not supported
Dear @rmarinho, will this fix be included in an 8.x.x release? We are currently facing an issue that should be resolved with this PR and we have not upgraded to .NET 9 |
@cvchris nop, this will be in a net9 service release only. |
Which service release will this fix be in? I just installed 9.0.200-preview.0.24575.35 but it is not working. Thanks! |
In .NET MAUI 9.0.30 (https://github.com/dotnet/maui/releases/tag/9.0.30), this PR is mentioned as a part of the release. 9.0.200-preview.0.24575.35 is a .NET SDK version, not a version of .NET MAUI. So you can either use .NET MAUI as nugets (you can do it right now) or wait for a new release of Visual Studio Preview (AFAIK). |
Description of Change
I've made some changes so that the
ObservableGroupedSource
resemblesObservableItemsSource
. It fixes the crash #25514 which I've observed on both CV and CV2Issues Fixed
Fixes #25514
Screen.Recording.2025-01-04.at.12.21.51.mov
Screen.Recording.2025-01-04.at.01.33.26.mov
@rmarinho what do you think?