Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix titlebar not being added to modals #26735

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

Foda
Copy link
Member

@Foda Foda commented Dec 19, 2024

Description of Change

Fixed the titlebar not being inherited on modals via Navigation.PushModalAsync

Issues Fixed

Fixes #26690

@Copilot Copilot bot review requested due to automatic review settings December 19, 2024 20:08
@Foda Foda requested a review from a team as a code owner December 19, 2024 20:08
@Foda Foda requested review from rmarinho and tj-devel709 December 19, 2024 20:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@PureWeen PureWeen added this to the .NET 9 SR2.2 milestone Dec 19, 2024
@PureWeen
Copy link
Member

PureWeen commented Dec 23, 2024

  • manual test has been added to validate this behavior
  • failing test unrelated

@PureWeen PureWeen merged commit 7ea9ddf into main Dec 23, 2024
102 of 104 checks passed
@PureWeen PureWeen deleted the foda/TitlebarNavModal branch December 23, 2024 22:18
@PureWeen
Copy link
Member

/backport to release/9.0.1xx-sr2

Copy link
Contributor

Started backporting to release/9.0.1xx-sr2: https://github.com/dotnet/maui/actions/runs/12473666150

@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Starting from 9.0.12 TitleBar Missing From Modal Pages
2 participants