Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radio button's default template improvements #26719

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Radio button's default template improvements #26719

merged 3 commits into from
Jan 29, 2025

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Dec 19, 2024 •
edited
Loading

Issues Fixed

Fixes #26689

<RadioButton
    Content="wwa"
    BackgroundColor="Red"
    HeightRequest="50"
    Margin="0,70,0,0"
    TextColor="Black"/>
Before After

@kubaflo kubaflo requested a review from a team as a code owner December 19, 2024 01:22
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 19, 2024
@PureWeen PureWeen added this to the .NET 9 SR4 milestone Dec 20, 2024
@PureWeen
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@jsuarezruiz jsuarezruiz self-assigned this Jan 15, 2025
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow
mattleibow previously approved these changes Jan 15, 2025
View reviewed changes
PureWeen
PureWeen requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like unit tests are failing

Border Style properties should not affect RadioButton(property: BindableProperty { DeclaringType = typeof(Microsoft.Maui.Controls.VisualElement), DefaultBindingMode = OneWay, DefaultValue = 0, IsReadOnly = False, PropertyName = "Rotation", ... }, value: 0.

@kubaflo kubaflo force-pushed the fix-26689 branch 2 times, most recently from dbe1b8e to 93130f4 Compare January 17, 2025 16:12
@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 17, 2025

The changes required unit tests adjustments

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit 5d50806 into dotnet:main Jan 29, 2025
102 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@mattleibow mattleibow mattleibow left review comments

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@jsuarezruiz jsuarezruiz

Labels
area-controls-radiobutton RadioButton, RadioButtonGroup community ✨ Community Contribution platform/android 🤖 platform/iOS 🍎 platform/windows 🪟
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9 SR4
Development

Successfully merging this pull request may close these issues.

Radiobutton not visible in .Net Maui on iOS 18
4 participants
@kubaflo @PureWeen @jsuarezruiz @mattleibow