Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadows & Gradients don't work with a list view's header/footer - fix #26637

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Shadows & Gradients don't work with a list view's header/footer - fix #26637

merged 2 commits into from
Dec 16, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Dec 14, 2024

Description of Change

Replaced .PlatformView with .ToPlatform() to respect a wrapperView

Issues Fixed

Fixes #26636

Before After

@kubaflo kubaflo requested review from jfversluis, jsuarezruiz and a team as code owners December 14, 2024 16:28
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 14, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jfversluis
Copy link
Member

jfversluis commented Dec 14, 2024 •
edited
Loading

/azp run

@azure-pipelines Azure Pipelines

This comment was marked as outdated.

Sign in to view
@jfversluis jfversluis added this to the .NET 9 Servicing milestone Dec 16, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho modified the milestones: .NET 9 Servicing, .NET 9 SR3 Dec 16, 2024
rmarinho
rmarinho requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test seem to be failing on Android

@kubaflo
Copy link
Contributor Author

kubaflo commented Dec 16, 2024

Test seem to be failing on Android

Is this test related to these changes?

@rmarinho rmarinho self-requested a review December 16, 2024 16:18
rmarinho
rmarinho approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I double check and these test failed in main also randomly . So this os good to go

@rmarinho rmarinho merged commit bfd3c34 into dotnet:main Dec 16, 2024
101 of 104 checks passed
@kubaflo
Copy link
Contributor Author

kubaflo commented Dec 16, 2024

Yeah I double check and these test failed in main also randomly . So this os good to go

This should help: #26657

@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees
No one assigned
Labels
area-controls-listview ListView and TableView community ✨ Community Contribution platform/android 🤖 platform/iOS 🍎
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9 SR3
Development

Successfully merging this pull request may close these issues.

[Android & iOS] Shadows & Gradients don't work with a list view's header/footer
3 participants
@kubaflo @jfversluis @rmarinho