Fix up relevant CA1416 warnings #26593
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jfversluis
added
the
area-infrastructure
mikeparker104
added
the
partner/cat 😻
This was referenced Dec 19, 2024
|
There is a chance that one issue with the CA1416 analyzer will get fixed in this PR: dotnet/roslyn-analyzers#7539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Unfortunately CA1416 still isn't reliable on iOS/Catalyst due to
dotnet/roslyn-analyzers#7239
You can work around the issue but it makes the code somewhat confusing to deal with, so we opted to not go the workaround path.
That being said, there were a lot of useful other bits that @stephen-hawley contributed into this PR #20477.
This PR pulls out all the bits that do fix some areas where we weren't checking for the right OperatingSystem Version and it converts to some newer APIS for iOS 18;