Fix Incorrect First and Last Visible Item index in CollectionView Scrolled Event #26468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikraja-arumugam
added
the
partner/syncfusion
jfversluis
added
the
area-controls-collectionview
devanathan-vaithiyanathan
requested review from
jfversluis,
jsuarezruiz and
a team
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-25649
branch
from
27dfde4 to
14a603a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Jan 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
In the CollectionView, the Scrolled event parameters FirstVisibleItemIndex and LastVisibleItemIndex return incorrect values.
Root Cause
The CollectionView includes the header at the zeroth index and the footer at the last index. As a result, the first and last visible item positions are updated without excluding the header and footer.
Description of Change
Implemented logic to calculate the first and last visible item positions, excluding the header and footer.
Issues Fixed
Fixes #25649
Validated the behaviour in the following platforms
Output Screenshot
BeforeFix.1.mp4
AfterFix.1.mp4