-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix android image loading race condition and improve logging #25870
Fix android image loading race condition and improve logging #25870
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
cea2228
to
9498be1
Compare
/rebase |
9498be1
to
5d2eda3
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/glide/GlideLogging.java
Show resolved
Hide resolved
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/glide/font/FontModel.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5d2eda3
to
7543596
Compare
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformLogger.java
Show resolved
Hide resolved
/rebase |
360e4d5
to
c2db931
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformInterop.java
Outdated
Show resolved
Hide resolved
src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/glide/MauiCustomViewTarget.java
Show resolved
Hide resolved
5f5a957
to
f3cf294
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logging changes look good now. 👍
But someone will need to manually test that it fixes: "android image loading race condition"
|
Description of Change
This PR aims to solve three issues:
Shell
Tab
s destroys theFragment
causing unwanted image unloading:Reloading images upon re-attach was handled in Check to see if Image Should Reload When Attached #24023 but we can provide a better UX here and avoid flashes while going back to the initial tab.
Glide is race-condition free, but we were setting the
Drawable
asynchronously in the next loop, this may generate glitches under some scrolling condition in collection viewGlide
integration:I've added proper logging mechanics which can be enabled via
adb
before running the application:Issues Fixed
#14587
#25783