Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix for frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame #25851

Merged
merged 3 commits into from
Jan 8, 2025
Merged

[Android] Fix for frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame #25851

merged 3 commits into from
Jan 8, 2025

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman commented Nov 14, 2024 •
edited
Loading

Root Cause of the Issue

  • When dynamically updating the GradientStops binding of the LinearGradientBrush used in the Frame background, the Frame's corner radius resets to 0, and the border color reverts to its default. This occurs because updating the GradientStops causes the backgroundDrawable to be disposed of and recreated, which leads to the default corner radius and border color being applied, resulting in this issue.

Description of Change

Issues Fixed

Fixes #23951

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 14, 2024
@jsuarezruiz jsuarezruiz added platform/android 🤖 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-controls-frame Frame labels Nov 14, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review November 15, 2024 09:50
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner November 15, 2024 09:50
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

/rebase

@rmarinho
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@PureWeen PureWeen dismissed jsuarezruiz’s stale review January 8, 2025 21:37

Changes addressed

@PureWeen PureWeen merged commit 29f3c7a into dotnet:main Jan 8, 2025
106 checks passed
@renovate renovate bot mentioned this pull request Jan 14, 2025
Open
1 task
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-frame Frame area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/android 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Frame disappears when assigning GradientStops to LinearGradientBrush inside this Frame
5 participants
@Tamilarasan-Paranthaman @jsuarezruiz @rmarinho @PureWeen @sheiksyedm