Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for [iOS] Use non-overridden traits in AppInfoImplementation.RequestTheme #25497

Merged
merged 8 commits into from
Jan 15, 2025

Conversation

SuthiYuvaraj
Copy link
Contributor

Root Cause

While updating the requested theme, the default TrailCollection is obtained, which does not return non-overridden traits and does not take the system theme into account.

Description of Change

UIScreen.MainScreen.TraitCollection is obtained , which will return non overridden traits based on the system theme

Issues Fixed

Fixes #23411

Output Video

Before Issue Fix After Issue Fix
BeforeFix.mov
AfterFix.mov

@karthikraja-arumugam
Copy link
Contributor

The fix ensures the theme updates correctly on the current page, but the main page still retains the previously requested theme, even when updating the application's current theme.

@filipnavara, do you have any thoughts on this?

@filipnavara
Copy link
Member

do you have any thoughts on this?

I'll have to check again what is going on in the test app. That sounds like the exact behavior this was trying to fix...

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@SuthiYuvaraj SuthiYuvaraj marked this pull request as ready for review October 30, 2024 13:06
@SuthiYuvaraj SuthiYuvaraj requested a review from a team as a code owner October 30, 2024 13:06
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Nov 6, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Nov 8, 2024
@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sheiksyedm
Copy link

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 6, 2024
@jfversluis jfversluis added the area-theme Themes, theming label Dec 9, 2024
@PureWeen PureWeen dismissed jsuarezruiz’s stale review January 7, 2025 19:15

Changes addressed

@mattleibow
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR3 milestone Jan 9, 2025
mattleibow
mattleibow previously approved these changes Jan 10, 2025
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue23411.xaml.cs(18,39): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-ios]

Removal async command
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

  • Failing tests are unrelated

@PureWeen PureWeen merged commit 517d5d7 into dotnet:main Jan 15, 2025
99 of 104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-theme Themes, theming community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/iOS 🍎
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[iOS] Application cannot be reset back to system theme
8 participants