Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] ClearButtonVisibility with margin fix #25392

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[Android] ClearButtonVisibility with margin fix #25392

merged 2 commits into from
Nov 26, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Oct 19, 2024

Issues Fixed

Fixes #25225

Before After
Screen.Recording.2024-10-19.at.14.33.48.mov
Screen.Recording.2024-10-19.at.14.35.17.mov

@kubaflo kubaflo requested a review from a team as a code owner October 19, 2024 13:30
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 19, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo requested a review from jsuarezruiz October 19, 2024 13:30
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho
Copy link
Member

/rebase

1 similar comment
@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@damusthe damusthe mentioned this pull request Nov 17, 2024
Closed
@jfversluis jfversluis enabled auto-merge (squash) November 26, 2024 10:30
@rmarinho rmarinho disabled auto-merge November 26, 2024 17:45
@rmarinho rmarinho merged commit 405c58a into dotnet:main Nov 26, 2024
105 of 108 checks passed
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@karthikraja-arumugam karthikraja-arumugam mentioned this pull request Dec 27, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jfversluis jfversluis jfversluis approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-entry Entry community ✨ Community Contribution fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! platform/android 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the component Entry, ClearButtonVisibility="WhileEditing" doesn't work.
6 participants
@kubaflo @jsuarezruiz @PureWeen @rmarinho @jfversluis @samhouts