[XC] Report XC0025 as an error only in strict compilation mode #25082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
report-xc0025-only-in-strict-compilation-mode
branch
from
475e2be to
4a0135c
Compare
StephaneDelcroix
approved these changes
Oct 15, 2024
jonathanpeppers
approved these changes
Oct 15, 2024
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11352818827 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We shouldn't report
XC0025(introduced in #24924) as an error even when the app hasTreatWarningsAsErrorsset totrueunless the app is in strict compilation mode (NativeAOT, full trimming, manually enabled). Leaving this as an error could make it more costly and difficult to migrate to .NET 9./cc @PureWeen