[Android] Add test for scroll without group #24288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foda
added
platform/android 🤖
i/regression
|
Looks like the test fails on iOS |
PureWeen
approved these changes
Aug 17, 2024
PureWeen
requested changes
Aug 17, 2024
PureWeen
approved these changes
Aug 19, 2024
Redth
pushed a commit
that referenced
this pull request
Aug 22, 2024
* Add test for scroll without group * Update CollectionViewTests.cs --------- Co-authored-by: Mike Corsaro <[email protected]>
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.1.24453.9
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When looking up the item index, using the interface
IGroupableItemsViewSourceto determine if the list is grouped or not will not work as ungrouped lists also implement that interface. This PR adjusts the logic to check if the list is ungrouped viaUngroupedItemsSource, then returns the index.Issues Fixed
Fixes #24272