Adds Tizen backend #2360

rookiejava · 2021-09-02T05:44:22Z

Description of Change

This PR adds Tizen backend.

Demo

- Weather `21

TV

- Mobile

Controls Sample

Special thanks to .NET MAUI folks (Yes, you!) for always helping us behind the scenes.

rmarinho · 2021-09-02T16:09:29Z

/azp run

azure-pipelines · 2021-09-02T16:09:52Z

Azure Pipelines successfully started running 2 pipeline(s).

mattleibow

This is a big PR! Only about 1/3 of the way, and already looking really good.

I have a few questions so far, but more not sure of the differences I spotted to what we did. Probably good reasons.

src/Compatibility/Core/src/Tizen/Extensions/BrushExtensions.cs

src/Core/src/Platform/MauiContext.Tizen.cs

src/Compatibility/Core/src/Tizen/Renderers/ActivityIndicatorRenderer.cs

src/Essentials/samples/Samples/Startup.cs

src/Core/src/ImageSources/IImageSourceService.cs

src/Core/src/Graphics/PaintExtensions.Tizen.cs

src/Essentials/samples/Samples/Startup.cs

src/Core/src/Platform/Tizen/SkiaGraphicsView.Tizen.cs

mattleibow · 2021-09-08T00:32:08Z

Were you able to get the DeviceTests projects working? I cheated a bit on Windows and excluded all the handlers except one for now - you could do the same. This way you can write tests for handlers/concepts that might be missed.

We might not have a way to run on CI on every commit just yet, but could be a way for you and us to just run and see if we broke anything before we release.

https://github.com/dotnet/maui/blob/main/src/Core/tests/DeviceTests/Core.DeviceTests.csproj#L66

rookiejava · 2021-09-08T04:49:33Z

Thank you @mattleibow for reviewing. ❤️

Were you able to get the DeviceTests projects working?

Ok. Let me check we can get the DeviceTest project.

rmarinho · 2021-09-09T13:08:20Z

/azp run

azure-pipelines · 2021-09-09T13:08:28Z

Pull request contains merge conflicts.

MartyIX · 2021-11-05T10:14:19Z

@rookiejava Will Tizen be supported by Microsoft if/when this PR is merged?

rookiejava · 2021-11-08T10:25:11Z

@rookiejava Will Tizen be supported by Microsoft if/when this PR is merged?

Yes, I think/hope so. :-)

…rols

mattleibow · 2022-04-15T05:08:01Z

/azp run

azure-pipelines · 2022-04-15T05:08:27Z

Azure Pipelines successfully started running 2 pipeline(s).

mattleibow · 2022-04-15T06:26:00Z

/azp run

azure-pipelines · 2022-04-15T06:26:27Z

Azure Pipelines successfully started running 2 pipeline(s).

mattleibow · 2022-04-15T06:50:09Z

/azp run

azure-pipelines · 2022-04-15T06:50:32Z

Azure Pipelines successfully started running 2 pipeline(s).

All the things have been thinged!

mattleibow · 2022-04-15T07:04:26Z

Directory.Build.props

+    <IncludeTizenTargetFrameworks Condition="'$(CI)' == 'true' or '$(TF_BUILD)' == 'true' or
+             Exists('$(DOTNET_ROOT)\sdk-manifests\$(DotNetVersionBand)\samsung.net.sdk.tizen\WorkloadManifest.json') or
+             Exists('$(ProgramFiles)\dotnet\sdk-manifests\$(DotNetVersionBand)\samsung.net.sdk.tizen\WorkloadManifest.json')">true</IncludeTizenTargetFrameworks>


This condition needs love, but that is for another PR. I see we had to also add TF_BUILD here because CI is declared in the Environment.props at the bottom of this file.

We plan to provide attrubute that check tizen workload is installed or not in next tizen workload release. So, MAUI just using this here.
/cc @JoonghyunCho will do. right? :)

I will give some love to this condition by replacing it to property after updating Tizen workload. :)

mattleibow · 2022-04-15T07:04:41Z

eng/pipelines/common/provision.yml

+    - pwsh: |
+        [xml] $fileXml = Get-Content "eng\Versions.props"
+        $DotNetVersionBand = $fileXml.SelectSingleNode("Project/PropertyGroup/DotNetVersionBand").InnerText
+        echo "Installing .NET $DotNetVersion"
+        Invoke-WebRequest 'https://raw.githubusercontent.com/Samsung/Tizen.NET/main/workload/scripts/workload-install.ps1' -OutFile 'workload-install.ps1'
+        .\workload-install.ps1 -t $DotNetVersion
+      displayName: 'Install Tizen'
+


I don't think this is needed anyore.

mattleibow · 2022-04-15T07:25:00Z

/azp run

azure-pipelines · 2022-04-15T07:25:24Z

Azure Pipelines successfully started running 2 pipeline(s).

congzhangzh · 2022-04-16T08:54:10Z

magic:)

rookiejava requested a review from Eilon as a code owner September 2, 2021 05:44

rookiejava force-pushed the add-tizen-handler branch 2 times, most recently from 95e73a5 to a8ddfab Compare September 7, 2021 09:36

mattleibow reviewed Sep 8, 2021

View reviewed changes

rookiejava force-pushed the add-tizen-handler branch from ab3b9e7 to 69fa16f Compare September 10, 2021 05:26

rookiejava force-pushed the add-tizen-handler branch 3 times, most recently from f7b6200 to 1892c8a Compare September 30, 2021 08:57

rookiejava force-pushed the add-tizen-handler branch 2 times, most recently from d84c486 to 03cc6e4 Compare October 12, 2021 06:43

rookiejava force-pushed the add-tizen-handler branch from 03cc6e4 to cb9a4d7 Compare October 14, 2021 09:25

Eilon added the area-setup Installation, setup, requirements, maui-check, workloads, platform support label Oct 18, 2021

rookiejava force-pushed the add-tizen-handler branch 2 times, most recently from 09f22ee to 9954658 Compare October 25, 2021 04:17

rookiejava force-pushed the add-tizen-handler branch from 34d73b5 to 482b65e Compare November 5, 2021 05:20

rookiejava force-pushed the add-tizen-handler branch from 482b65e to 3cbb053 Compare November 9, 2021 10:03

rookiejava force-pushed the add-tizen-handler branch 3 times, most recently from 1868bdf to 3b60dd0 Compare November 23, 2021 00:45

rookiejava force-pushed the add-tizen-handler branch 2 times, most recently from e962b53 to f044413 Compare December 7, 2021 09:51

rookiejava force-pushed the add-tizen-handler branch from 7c284ee to 29f7d25 Compare December 13, 2021 09:51

rookiejava added 8 commits April 15, 2022 07:48

[Tizen] Initial support for configuring the underlying Web view settings

241370b

[Tizen] BlazorWebView public API tracking

1308c47

[Tizen] use latest tizen workload as default

2952b6d

[Tizen] specify sdk version to avoid ci build error

4e4a86c

[Tizen] Keep the text wrapping/truncation and max lines stuff in Cont…

544de1a

…rols

[Tizen] Remove downcasts in BlazorWebView

841b243

[Tizen] BlazorWebView API review changes: Shared sources

41c0e63

[Tizen] add tizen TFM optional

49475bc

rookiejava force-pushed the add-tizen-handler branch from a38b74d to 49475bc Compare April 14, 2022 23:13

[Tizen] adding informative comments for template

5a0e923

[Tizen] Set IncludeTizenTargetFrameworks correctly

a532171

rookiejava force-pushed the add-tizen-handler branch from 6683b0a to a532171 Compare April 15, 2022 06:48

mattleibow approved these changes Apr 15, 2022

View reviewed changes

mattleibow enabled auto-merge (squash) April 15, 2022 07:07

[Tizen] install maui-tizen

9aad3cb

auto-merge was automatically disabled April 15, 2022 07:24
Head branch was pushed to by a user without write access

mattleibow enabled auto-merge (squash) April 15, 2022 07:24

mattleibow merged commit 438aef2 into dotnet:main Apr 15, 2022

github-actions bot locked and limited conversation to collaborators Dec 25, 2023

samhouts added the fixed-in-6.0.300-rc.2 Look for this fix in 6.0.300-rc.2! label Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Tizen backend #2360

Adds Tizen backend #2360

rookiejava commented Sep 2, 2021

rmarinho commented Sep 2, 2021

azure-pipelines bot commented Sep 2, 2021

mattleibow left a comment

mattleibow commented Sep 8, 2021

rookiejava commented Sep 8, 2021

rmarinho commented Sep 9, 2021

azure-pipelines bot commented Sep 9, 2021

MartyIX commented Nov 5, 2021

rookiejava commented Nov 8, 2021

mattleibow commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

mattleibow commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

mattleibow commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

mattleibow Apr 15, 2022

rookiejava Apr 15, 2022

JoonghyunCho Apr 15, 2022

mattleibow Apr 15, 2022

mattleibow commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

congzhangzh commented Apr 16, 2022

Adds Tizen backend #2360

Adds Tizen backend #2360

Conversation

rookiejava commented Sep 2, 2021

Description of Change

Demo

- Weather `21

Controls Sample

rmarinho commented Sep 2, 2021

azure-pipelines bot commented Sep 2, 2021

mattleibow left a comment

Choose a reason for hiding this comment

mattleibow commented Sep 8, 2021

rookiejava commented Sep 8, 2021

rmarinho commented Sep 9, 2021

azure-pipelines bot commented Sep 9, 2021

MartyIX commented Nov 5, 2021

rookiejava commented Nov 8, 2021

mattleibow commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

mattleibow commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

mattleibow commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

mattleibow Apr 15, 2022

Choose a reason for hiding this comment

rookiejava Apr 15, 2022

Choose a reason for hiding this comment

JoonghyunCho Apr 15, 2022

Choose a reason for hiding this comment

mattleibow Apr 15, 2022

Choose a reason for hiding this comment

mattleibow commented Apr 15, 2022

azure-pipelines bot commented Apr 15, 2022

congzhangzh commented Apr 16, 2022