Ignore visual tests on iPhone 15 devices #18407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BretJohnson
requested review from
mattleibow and
jsuarezruiz
and removed request for
a team
rmarinho
deleted the
dev/bretjohn/skip-visual-tests-on-iphone15-currently
branch
rmarinho
added a commit
that referenced
this pull request
Oct 31, 2023
* Bum xharness for rtm * Fix ios cake * Add ios17 * Update device-tests.yml * [tests] Try fix test crash on iOS17 * [tests] Add code to launch on device * Skip test on iOS17 * Try fix UITests * Pass device name * Fix run uitests with correct dotnet * Update Compatibility.ControlGallery.iOS.csproj * Fix this * Ignore visual tests on iPhone 15 devices (#18407) * Fix TapTwoPlacesQuickly on IOS17 --------- Co-authored-by: Shane Neuville <[email protected]> Co-authored-by: Bret Johnson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
For now, skip visual tests on iPhone 15 devices (iOS 17), only running visual tests on iPhone X devices like we've done traditionally.