Rework the Label mappers for FormattedText #18105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
jsuarezruiz
and removed request for
jfversluis
mattleibow
force-pushed
the
dev/propagate-label-properties
branch
from
6bae69d to
643235c
Compare
Eilon
added
the
legacy-area-controls
mattleibow
force-pushed
the
dev/propagate-label-properties
branch
from
643235c to
da19bf2
Compare
jsuarezruiz
reviewed
Oct 19, 2023
The current implementation did not recreate the FormattedText spans when certain properties changed: Font and TextColor
mattleibow
force-pushed
the
dev/propagate-label-properties
branch
from
da19bf2 to
4db51b0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
samhouts
approved these changes
Oct 20, 2023
rmarinho
approved these changes
Oct 23, 2023
|
/backport to release/8.0.1xx-rc2.1 |
|
Started backporting to release/8.0.1xx-rc2.1: https://github.com/dotnet/maui/actions/runs/6615461540 |
Eilon
added
area-controls-label
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The current implementation did not recreate the FormattedText spans when certain properties changed:
iOS explicitly handled these properties and then did not actually apply them.
Android did not handle it at all.
Issues Fixed
Fixes #17938
Tasks
UI Tests