[android] update AOT profile for .NET 8.0.100-rc.2.23468.1 #17624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recorded this profile with current dotnet/maui/main merged into the
`net8.0` branch. I wanted to make sure latest changes in MAUI were in
the profile.
An average of 10 runs of a dotnet new maui app on a Pixel 5, the new
profile gives us some good numbers:
Average(ms): 589.4
Std Err(ms): 4.28226316073379
Std Dev(ms): 13.5417051281505
Previously, in edb7f12 .NET 8 RC 1 we got:
Average(ms): 607.8
Std Err(ms): 2.94316534061922
Std Dev(ms): 9.307106006822
Before that in 3f22153 we got:
Average(ms): 588.5
Std Err(ms): 2.21233913413935
Std Dev(ms): 6.99603062060512
With these results, I believe we have solved any startup regressions
that were present in .NET 8 RC 1.
Most notably, I think these two helped the most:
* dotnet/android@eb6397d
* dotnet/runtime@fecf3ee
jonathanpeppers
commented
Sep 25, 2023
Comment on lines
-1642
to
-1646
| Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder/GeneratedMethod Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder:<.ctor>b__14_0 (Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCacheKey,Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite) | ||
| Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder/GeneratedMethod Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder:BuildType (Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite) | ||
| Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder/GeneratedMethod Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder:BuildTypeNoCache (Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite) | ||
| Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder/GeneratedMethod System.Collections.Concurrent.ConcurrentDictionary`2<Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCacheKey, Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder/GeneratedMethod>:GetOrAdd (Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCacheKey,System.Func`3<Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCacheKey, Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite, Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder/GeneratedMethod>,Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite) | ||
| Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder/ILEmitResolverBuilderRuntimeContext Microsoft.Extensions.DependencyInjection.ServiceLookup.ILEmitResolverBuilder:GenerateMethodBody (Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceCallSite,System.Reflection.Emit.ILGenerator) |
There was a problem hiding this comment.
It's good Microsoft.Extensions is not using System.Reflection.Emit anymore.
rmarinho
approved these changes
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recorded this profile with current dotnet/maui/main merged into the
net8.0branch. I wanted to make sure latest changes in MAUI were in the profile.An average of 10 runs of a dotnet new maui app on a Pixel 5, the new profile gives us some good numbers:
Previously, in edb7f12 .NET 8 RC 1 we got:
Before that in 3f22153 we got:
With these results, I believe we have solved any startup regressions that were present in .NET 8 RC 1.
Most notably, I think these two helped the most: