Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X] Double cast for OnPlat in StaticResource #17545

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[X] Double cast for OnPlat in StaticResource #17545

merged 1 commit into from
Sep 25, 2023

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

When OnPlatform is used as a StaticResource, cast it first to T (extract the Onplatform value), then process as usual, and cast it again to propertyType if needed

Issues Fixed

@StephaneDelcroix
[X] Double cast for OnPlat in StaticResource
c02405a 
When OnPlatform<T> is used as a StaticResource, cast it first to T
(extract the Onplatform value), then process as usual, and cast it again
to propertyType if needed

- fixes #16327
@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner September 21, 2023 13:29
@Eilon Eilon added the area-xaml XAML, CSS, Triggers, Behaviors label Sep 21, 2023
@PureWeen PureWeen merged commit e69c7bd into main Sep 25, 2023
@PureWeen PureWeen deleted the fix_16327 branch September 25, 2023 19:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts approved these changes

@hartez hartez Awaiting requested review from hartez hartez is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rachelkang rachelkang Awaiting requested review from rachelkang rachelkang is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using Int32 as a resource for the parameter for <RoundRectangle CornerRadius="">
4 participants
@StephaneDelcroix @samhouts @Eilon @PureWeen