Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null check everything in InvalidateMeasureIfContentSizeChanged #17472

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Null check everything in InvalidateMeasureIfContentSizeChanged #17472

merged 1 commit into from
Sep 19, 2023

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Sep 19, 2023

Description of Change

Just null check everything.

Issues Fixed

Doesn't really fix #17208, but it might prevent the crash.

@samhouts samhouts added this to the .NET 8 GA milestone Sep 19, 2023
@PureWeen PureWeen marked this pull request as ready for review September 19, 2023 20:48
@PureWeen PureWeen requested a review from a team as a code owner September 19, 2023 20:48
@PureWeen PureWeen merged commit d0192d6 into main Sep 19, 2023
@PureWeen PureWeen deleted the ivc-null-checks branch September 19, 2023 20:49
@PureWeen
Copy link
Member

/backport to net7.0

@github-actions
Copy link
Contributor

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/6240785716

@github-actions github-actions bot mentioned this pull request Sep 19, 2023
Merged
@PureWeen PureWeen mentioned this pull request Sep 19, 2023
Open
@rmarinho rmarinho added the backport/suggested The PR author or issue review has suggested that the change should be backported. label Sep 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@rachelkang rachelkang Awaiting requested review from rachelkang rachelkang is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
backport/suggested The PR author or issue review has suggested that the change should be backported. fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373!
Projects
None yet
Milestone
.NET 8 GA
Development

Successfully merging this pull request may close these issues.
4 participants
@hartez @PureWeen @rmarinho @samhouts