Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Mac Catalyst Core Device Tests in CI #17232

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Enable Mac Catalyst Core Device Tests in CI #17232

merged 5 commits into from
Sep 7, 2023

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Sep 6, 2023 •
edited
Loading

Description of Change

Enables the Core projects device tests for Mac Catalyst. A couple of things to note:

  • SearchBarHandlerTests.BackgroundInitializesCorrectly(uint color) is disabled as per the comment in code that points to: Fix test SearchBarHandlerTests.BackgroundInitializesCorrectly on iOS #13693 the issue here also applies to macOS
  • All but one of the WindowHandlerTests tests are skipped for Mac Catalyst. Somehow on macOS the OnCreated for window hangs, we will need to investigate why. This is the point that hangs meaning that somehow this goes wrong. I've added it to the todo list in UITests/DeviceTests TODOS  #15113
  • This adds an environment variable that is only set when the tests are running headless. Somehow Mac Catalyst has trouble finding the KeyWindow when running headless. To fix that there is the env variable and we return the first window we find in this scenario to fix the tests.

Issues Fixed

Related to #11236

@jfversluis jfversluis added platform/macOS 🍏 macOS / Mac Catalyst t/housekeeping ♻︎ area-testing Unit tests, device tests labels Sep 6, 2023
@jfversluis jfversluis force-pushed the catalyst-core-devicetests branch from 9957b1a to 7ecc7eb Compare September 7, 2023 08:01
@jfversluis jfversluis mentioned this pull request Sep 7, 2023
Open
40 tasks
@jfversluis jfversluis marked this pull request as ready for review September 7, 2023 13:38
@jfversluis jfversluis requested a review from a team as a code owner September 7, 2023 13:38
@PureWeen PureWeen force-pushed the catalyst-core-devicetests branch from 9638549 to e69cdf7 Compare September 7, 2023 16:13
@rmarinho rmarinho enabled auto-merge (squash) September 7, 2023 17:46
@rmarinho rmarinho merged commit 2068ae8 into main Sep 7, 2023
@rmarinho rmarinho deleted the catalyst-core-devicetests branch September 7, 2023 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartyIX MartyIX MartyIX left review comments

@mattleibow mattleibow mattleibow approved these changes

@rmarinho rmarinho rmarinho approved these changes

@PureWeen PureWeen PureWeen approved these changes

@jknaudt21 jknaudt21 jknaudt21 approved these changes

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz jsuarezruiz is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@rachelkang rachelkang Awaiting requested review from rachelkang rachelkang is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-testing Unit tests, device tests fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! platform/macOS 🍏 macOS / Mac Catalyst t/housekeeping ♻︎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jfversluis @MartyIX @mattleibow @rmarinho @PureWeen @jknaudt21 @samhouts