Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Factory Registration to fix ListView regression #17084

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Revert Factory Registration to fix ListView regression #17084

merged 5 commits into from
Aug 30, 2023

Conversation

PureWeen
Copy link
Member

Description of Change

Currently the ListView is crashing with this set of changes.

Issues Fixed

Fixes #17028

@PureWeen
Revert "[core] factory methods for registering services, part 2 (#17004…
ed9a1fc 
…)"

This reverts commit 79a44ff.
@PureWeen
Revert "[android] fix DI registration for Frame, ListView, TableView (#…
fb2fc87 
…16989)"

This reverts commit 136f21d.
@PureWeen
Revert "[core] use factory methods for registering services (#16741)"
292cbc5 
This reverts commit b0bba51.

# Conflicts:
#	src/Controls/src/Xaml/Hosting/AppHostBuilderExtensions.cs
#	src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt
jonathanpeppers
jonathanpeppers requested changes Aug 29, 2023
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert less? We shouldn't have to revert all 3 of these.

@jonathanpeppers
Copy link
Member

Can you share some details on what is wrong with these changes? What is the error, how do I reproduce it?

@PureWeen
Revert "Revert "[core] factory methods for registering services, part…
e96c179 
… 2 (#17004)""

This reverts commit ed9a1fc.

# Conflicts:
#	eng/BannedSymbols.txt
#	src/BlazorWebView/src/SharedSource/BlazorWebViewServiceCollectionExtensions.cs
@PureWeen PureWeen marked this pull request as ready for review August 29, 2023 22:03
@PureWeen PureWeen requested a review from a team as a code owner August 29, 2023 22:03
@PureWeen PureWeen requested a review from hartez August 29, 2023 22:03
@PureWeen
Copy link
Member Author

Can you share some details on what is wrong with these changes? What is the error, how do I reproduce it?

Yea, I've linked @drasticactions issue in the description #17084 (comment)

The other way to reproduce is through the legacy tests.

  • build the build tasks
  • open Microsoft.Maui.sln
  • run the Android Control GAllery
  • "go to tests"
  • N0 - ListView ViewCell binding
    image
  • click remove

jonathanpeppers
jonathanpeppers approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This puts the public API changes back now.

@PureWeen PureWeen enabled auto-merge (squash) August 30, 2023 02:19
@PureWeen PureWeen merged commit 6bc5ea9 into main Aug 30, 2023
@PureWeen PureWeen deleted the factory_revert branch August 30, 2023 10:14
jonathanpeppers added a commit to jonathanpeppers/maui that referenced this pull request Sep 7, 2023
@jonathanpeppers
Revert "Revert Factory Registration to fix ListView regression (dotne…
8401b96 
…t#17084)"

This reverts commit 6bc5ea9.

Will manually run the UI Tests here to understand what was going wrong
with the original changes.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@rmarinho rmarinho rmarinho approved these changes

@hartez hartez Awaiting requested review from hartez hartez is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[regression/8.0.0-rc1] [Android] Removing ItemSource item in ListView causes crash
4 participants
@PureWeen @jonathanpeppers @rmarinho @samhouts