Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pinning to NET7 SDK #17035

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Remove pinning to NET7 SDK #17035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,5 @@
"msbuild-sdks": {
"MSBuild.Sdk.Extras": "3.0.44",
"Microsoft.Build.NoTargets": "3.3.0"
},
"sdk": {
"version": "7.0.200",
"allowPrerelease": true,
"rollForward": "major"
Comment on lines -9 to -12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these lines is very similar behavior to it being here. rollForward=major allows it to use .NET 8 SDKs.

Either way, seems fine to just delete these as even the .NET team doesn't really suggest using global.json by default -- it's more of something for working around a problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I was thinking with your edits it should be using .NET8.

But mine was still using .NET 7 when I had these there. I had to delete them in order for VS or the CLI to use .NET8.

image

image

}
}