Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[housekeeping] Automated PR to fix formatting errors #17017

Merged
merged 1 commit into from
Aug 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ internal void UpdateTitle()
{
MapMenuItems();
}

void UpdateCurrentItem()
{
if (_currentShellSection == VirtualView.CurrentItem)
Expand Down Expand Up @@ -444,7 +444,7 @@ public static void MapTitle(ShellItemHandler handler, ShellItem item)
{
handler.UpdateTitle();
}

public static void MapCurrentItem(ShellItemHandler handler, ShellItem item)
{
handler.UpdateCurrentItem();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ protected override WFrame CreatePlatformElement()
return new WFrame();
}
public static void MapTitle(ShellSectionHandler handler, ShellSection item)
{
{
var shellItem = item.Parent as ShellItem;
var shellItemHandler = shellItem?.Handler as ShellItemHandler;
shellItemHandler?.UpdateTitle();
}

public static void MapCurrentItem(ShellSectionHandler handler, ShellSection item)
{
handler.SyncNavigationStack(false, null);
Expand Down
2 changes: 1 addition & 1 deletion src/Controls/src/Core/Layout/Layout.cs
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public void Insert(int index, IView child)

if (child is Element element)
InsertLogicalChild(index, element);

_children.Insert(index, child);

OnInsert(index, child);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ public void AddFlyoutItem(string text)
flyout.Add(flyoutItem);
}

public void RemoveFlyoutItem(int index)
public void RemoveFlyoutItem(int index)
{
flyout.RemoveAt(index);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ await InvokeOnMainThreadAsync(async () =>
Assert.True(label.Height <= grid.MaximumHeightRequest);
Assert.True(grid.Height <= grid.MaximumHeightRequest);
}

[Fact]
public async Task GridAddAndRemoveChildrenViaIndex()
{
Expand All @@ -303,7 +303,7 @@ public async Task GridAddAndRemoveChildrenViaIndex()

await InvokeOnMainThreadAsync(async () =>
{
await AttachAndRun(grid, (handler) =>
await AttachAndRun(grid, (handler) =>
{
Assert.True((grid[1] as Label).Text == "Hello world");

Expand All @@ -325,7 +325,7 @@ await AttachAndRun(grid, (handler) =>
});
});
}

/* Commented out of for now due to inconsistent platform behavior
[Fact("Ensures grid rows renders the correct size - Issue 15330")]
public async Task Issue15330()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
using Microsoft.Maui.Controls;
using Microsoft.Maui.Controls.Handlers;
using Microsoft.Maui.Controls.Platform;
using Microsoft.Maui.DeviceTests.Stubs;
using Microsoft.Maui.Graphics;
using Microsoft.Maui.Platform;
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Controls;
using Microsoft.Maui.DeviceTests.Stubs;
using Xunit;
using NavigationView = Microsoft.UI.Xaml.Controls.NavigationView;
using WFrameworkElement = Microsoft.UI.Xaml.FrameworkElement;
Expand Down
2 changes: 1 addition & 1 deletion src/Controls/tests/UITests/Tests/Issues/Issue12211.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class Issue12211 : _IssuesUITest
private string buttonId = "ChangeOpacity";

public Issue12211(TestDevice device) : base(device)
{
{
}

public override string Issue => "[Android] BoxView Opacity not working";
Expand Down
2 changes: 1 addition & 1 deletion src/Controls/tests/UITests/Tests/Issues/Issue15357.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class Issue15357 : _IssuesUITest
private string buttonId = "ButtonClick";

public Issue15357(TestDevice device) : base(device)
{
{
}

public override string Issue => "IsVisible binding not showing items again if Shadow is set";
Expand Down
2 changes: 1 addition & 1 deletion src/Controls/tests/UITests/Tests/Issues/Issue15826.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class Issue15826 : _IssuesUITest
private string buttonId = "Swap";

public Issue15826(TestDevice device) : base(device)
{
{
}

public override string Issue => "ListView visibility doesn't work well";
Expand Down