[iOS] Avoid CheckBox memory leak #16376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
platform/iOS 🍎
legacy-area-perf
ghost
added
the
legacy-area-controls
rmarinho
reviewed
Jul 26, 2023
|
Do we need the API change? shouldn't it be nullable?! |
PureWeen
reviewed
Jul 27, 2023
| @@ -30,5 +43,31 @@ public async Task UpdatingCheckBoxBackgroundColorUpdatesBackground(string colorS | |||
|
|
|||
| await ValidateHasColor<CheckBoxHandler>(checkBox, color); | |||
| } | |||
|
|
|||
| [Fact(DisplayName = "Does Not Leak")] | |||
| public async Task DoesNotLeak() | |||
There was a problem hiding this comment.
@jonathanpeppers does it make sense to standardize these tests? These are all basically the same format yea? Can we just use InlineData or a class to provide all the control types and just permutate through them all?
There was a problem hiding this comment.
I can do that after the current round of PRs are in.
It could probably be a parameterized test in MemoryTests.cs, as long as the test is reasonably searchable/runnable in the device tests menu.
Right, changed. |
rmarinho
approved these changes
Jul 27, 2023
Eilon
added
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Avoid CheckBox leak on iOS.
