Fix infinite recursion error in CommandMapper.Add() #16264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @agaluzzi! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree |
mattleibow
approved these changes
Jul 21, 2023
|
/azp run |
|
No commit pushedDate could be found for PR 16264 in repo dotnet/maui |
jsuarezruiz
approved these changes
Jul 21, 2023
|
/azp run |
|
No commit pushedDate could be found for PR 16264 in repo dotnet/maui |
|
/azp run |
|
No commit pushedDate could be found for PR 16264 in repo dotnet/maui |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This commit fixes a problem in
CommandMapperwhere theAdd(string key, Action<TViewHandler, TVirtualView> action)method is simply calling itself, causing infinite recursion (stack overflow).Issues Fixed
Fixes #16263