Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix Keyboard.Numeric issue #16163

Merged
merged 6 commits into from
Aug 25, 2023
Merged

[Android] Fix Keyboard.Numeric issue #16163

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
37bc13b
Fix Keyboard.Numeric issue on DisplayPromptAsync on Android
jsuarezruiz Jul 10, 2023
1271063
Merge branch 'main' into fix-11865
jsuarezruiz Jul 18, 2023
134adcf
Merge branch 'main' into fix-11865
jsuarezruiz Jul 25, 2023
fa3e977
Merge branch 'main' into fix-11865
jsuarezruiz Aug 11, 2023
8ca5a11
Merge branch 'main' into fix-11865
jsuarezruiz Aug 16, 2023
f80b6a8
Remove AlertsPage sample
rachelkang Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/src/Platform/Android/LocalizedDigitsKeyListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ bool IsDecimalPointChar(char c)
}
}

return stripped ?? filterFormatted ?? new String("");
return stripped ?? filterFormatted;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to fix the issue, but can you help me understand why? Why wasn't it working before with other system display languages and why does it work now with this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Why??? 😭

}
#pragma warning restore CS8602 // Dereference of a possibly null reference.
}
Expand Down