Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to Colors.xaml to make people aware of Android specific colors #15855

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

jfversluis
Copy link
Member

Description of Change

Until we have some way of also updating or not using the Platforms\Android\Resources\values\colors.xml for Android anymore, let's make sure people know about its existence.

Issues Fixed

Fixes #9039

@jfversluis jfversluis added t/housekeeping ♻︎ area-templates Project templates, Item Templates for Blazor and MAUI labels Jun 26, 2023
@rmarinho rmarinho requested a review from rachelkang June 26, 2023 13:55
</ResourceDictionary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: validate spacing / remove change as needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chatted offline; realized it's just a newline was added. cool!

@rachelkang rachelkang merged commit f70f1d0 into main Jul 3, 2023
@rachelkang rachelkang deleted the jfversluis-patch-1 branch July 3, 2023 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.7.8842 Look for this fix in 8.0.0-preview.7.8842! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI fixed-in-8.0.0-preview.7.8842 Look for this fix in 8.0.0-preview.7.8842! platform/android 🤖 t/housekeeping ♻︎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comment to Colors.xaml about Android specific colors
3 participants