Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android x nuget bumps #15746

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Android x nuget bumps #15746

merged 4 commits into from
Jun 21, 2023

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jun 20, 2023

Description of Change

This PR removes the use of any private APIs that we are using on the NavigationController.

With 2.6.0 google completely removed the BackQueue API so we needed to find a more "official" way to do the same thing. The code we switched to isn't great because it throws as it's iterating but currently that's the best way I've found to iterate over the current back stack.

Fixes for #15685

@PureWeen PureWeen requested review from rmarinho and moljac June 20, 2023 19:42
Copy link
Contributor

@moljac moljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eilon Eilon added the area-core-platform Integration with platforms label Jun 20, 2023
@PureWeen PureWeen marked this pull request as ready for review June 20, 2023 21:33
@PureWeen PureWeen changed the title Android x updates Android x nuget bumps Jun 20, 2023
@rmarinho rmarinho merged commit dd8f82a into main Jun 21, 2023
@rmarinho rmarinho deleted the AndroidXUpdates branch June 21, 2023 09:48
mattleibow pushed a commit that referenced this pull request Sep 1, 2023
* Android ecosystem nugets bumped

* - remove backqueue

* - fix tests

* - fix back navigation visibility

---------

Co-authored-by: moljac <[email protected]>
# Conflicts:
#	eng/AndroidX.targets
#	eng/Versions.props
#	src/Controls/src/Core/NavigationPage.cs
#	src/Controls/tests/DeviceTests/Elements/NavigationPage/NavigationPageTests.cs
#	src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.6.8686 Look for this fix in 8.0.0-preview.6.8686! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-core-platform Integration with platforms fixed-in-8.0.0-preview.6.8686 Look for this fix in 8.0.0-preview.6.8686! platform/android 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants