[android] AOT profiles for .NET 8 Preview 4 #14838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the profile, following the instructions in:
src/ProfiledAot/README.md
Testing a `dotnet new maui` project on a Pixel 5:
Before:
Average(ms): 568
Std Err(ms): 2.21610268514595
Std Dev(ms): 7.00793201387621
After:
Average(ms): 548.5
Std Err(ms): 2.65518360947035
Std Dev(ms): 8.39642781187333
Most notably calls to System.Reflection.Emit are now gone, after we
landed:
dotnet/android#7972
jonathanpeppers
commented
Apr 28, 2023
Comment on lines
-7135
to
-7152
| void System.Reflection.Emit.DynamicMethod:.cctor () | ||
| void System.Reflection.Emit.DynamicMethod:.ctor (string,System.Type,System.Type[],System.Reflection.Module,bool) | ||
| void System.Reflection.Emit.DynamicMethod:create_dynamic_method (System.Reflection.Emit.DynamicMethod,string,System.Reflection.MethodAttributes,System.Reflection.CallingConventions) | ||
| void System.Reflection.Emit.DynamicMethod:CreateDynMethod () | ||
| void System.Reflection.Emit.DynamicMethod:Init (string,System.Reflection.MethodAttributes,System.Reflection.CallingConventions,System.Type,System.Type[],System.Type,System.Reflection.Module,bool,bool) | ||
| void System.Reflection.Emit.ILGenerator:.ctor (System.Reflection.Module,System.Reflection.Emit.ITokenGenerator,int) | ||
| void System.Reflection.Emit.ILGenerator:Emit (System.Reflection.Emit.OpCode,int) | ||
| void System.Reflection.Emit.ILGenerator:Emit (System.Reflection.Emit.OpCode,System.Reflection.ConstructorInfo) | ||
| void System.Reflection.Emit.ILGenerator:Emit (System.Reflection.Emit.OpCode,System.Reflection.FieldInfo) | ||
| void System.Reflection.Emit.ILGenerator:Emit (System.Reflection.Emit.OpCode,System.Reflection.MethodInfo) | ||
| void System.Reflection.Emit.ILGenerator:Emit (System.Reflection.Emit.OpCode,System.Type) | ||
| void System.Reflection.Emit.ILGenerator:Emit (System.Reflection.Emit.OpCode) | ||
| void System.Reflection.Emit.ILGenerator:emit_int (int) | ||
| void System.Reflection.Emit.ILGenerator:label_fixup (System.Reflection.MethodBase) | ||
| void System.Reflection.Emit.ILGenerator:ll_emit (System.Reflection.Emit.OpCode) | ||
| void System.Reflection.Emit.ILGenerator:make_room (int) | ||
| void System.Reflection.Emit.OpCodes:.cctor () | ||
| void System.Reflection.Emit.RuntimeModuleBuilder:.cctor () |
There was a problem hiding this comment.
Yay! These are gone now.
mattleibow
approved these changes
Apr 29, 2023
Eilon
added
the
t/perf
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the profile, following the instructions in:
Testing a
dotnet new mauiproject on a Pixel 5:Most notably calls to System.Reflection.Emit are now gone, after we landed:
dotnet/android#7972