[net8.0] Update dependencies from xamarin/xamarin-android #12893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…uild main-953cd1939d309e0affe610728a79ede865a3bb75-1 Microsoft.Android.Sdk.Windows From Version 34.0.0-preview.1.127 -> To Version 34.0.0-preview.1.129
ghost
added
the
area-infrastructure
Context: dotnet/android@953cd19 By setting `$(AndroidGenerateResourceDesigner)` appropriately, we can avoid some of the public APIs that appeared in eea6fea. It is turned off repo-wide, and only enabled in `Core.csproj` and `Compatibility.csproj`. These two projects use `@(AndroidResource)` files, so they require this.
MSBuild ordering was breaking the settings here. The Android workload defaults $(AndroidGenerateResourceDesigner) to true, but we need to know if it was set in individual .csproj files. Invented a new property name for this.
Eilon
approved these changes
Jan 25, 2023
jonathanpeppers
approved these changes
Jan 25, 2023
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@rmarinho do you know why I have to comment: We had to do this here, too: #12520 (comment) |
|
@mattleibow @Redth would someone else be able to review? It says:
|
rmarinho
approved these changes
Jan 26, 2023
jonathanpeppers
deleted the
darc-net8.0-b7913c9e-5b64-4783-9019-f58b6768d266
branch
rmarinho
pushed a commit
that referenced
this pull request
Jan 27, 2023
Changes: dotnet/android@c1efcb5...953cd19 Updates: * Microsoft.Android.Sdk.Windows: from 34.0.0-preview.1.127 to 34.0.0-preview.1.129 ~~ Other Changes ~~ * [android] set `$(AndroidGenerateResourceDesigner)` Context: dotnet/android@953cd19 By setting `$(AndroidGenerateResourceDesigner)` appropriately, we can avoid some of the public APIs that appeared in eea6fea. It is turned off repo-wide, and only enabled in three projects. These projects use `@(AndroidResource)` files, so they require this. * Use `$(MauiGenerateResourceDesigner)` to opt in MSBuild ordering require us to invent a new property. The Android workload defaults `$(AndroidGenerateResourceDesigner)` to true, but we need to know if it was set in individual .csproj files. Co-authored-by: Jonathan Peppers <[email protected]>
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/xamarin/xamarin-android