Fix Switch Off Track Color - Fixes #10099 #10758

tj-devel709 · 2022-10-18T13:38:21Z

The customer points out that when a switch track color is set, the switch is turned on, then when the switch is turned off, the switch track color stays on which is not the expected behavior. See below:

Original Incorrect Behavior

Adjusted Behavior

After the fix from this PR, the switch works as expected:

iOS	Android

Customer reported issues in both android and iOS when using the VisualStateManager, but android worked fine for me without any fixes as shown above

tj-devel709 · 2022-10-18T16:00:12Z

Needs tests 😋

src/Core/src/Platform/iOS/SwitchExtensions.cs

hartez

Let's guard against NREs here.

src/Core/src/Platform/iOS/SwitchExtensions.cs

tj-devel709 · 2022-11-08T19:57:31Z

I added the NRE checks fine, but the tests that I added started failing again locally for other reasons. I am looking into it some more, but it seems that the UIView that I get into my test is different (different handle at least) and the colors that were set are not set for the argument passed into my test. Visually, things work as expected though..

tj-devel709 · 2022-11-10T17:33:32Z

/azp run

azure-pipelines · 2022-11-10T17:33:49Z

Azure Pipelines successfully started running 2 pipeline(s).

github-actions · 2023-03-29T18:02:17Z

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

…rackColor

tj-devel709 · 2023-03-29T21:07:38Z

@PureWeen @mattleibow @mandel-macaque This one should be good now!

PureWeen · 2023-03-30T17:08:30Z

src/Core/src/Platform/iOS/SwitchExtensions.cs

 			if (OperatingSystem.IsIOSVersionAtLeast(13) || OperatingSystem.IsTvOSVersionAtLeast(13))
-				uIView = uISwitch.Subviews[0].Subviews[0];
+				return uISwitch.Subviews?.FirstOrDefault()?.Subviews?.FirstOrDefault();


Can we not use linq for this?
Just make it a long if statement or nested?

We typically just stay away from LINQ for performance reasons.

I'm going to agree, there is nothing nice we can do. Sometimes code has to be ugly and work.

@mandel-macaque and @PureWeen updated! Thanks for the idea!

PureWeen · 2023-03-31T20:21:24Z

src/Core/src/Platform/iOS/SwitchExtensions.cs

 		}

 		internal static UIColor? GetTrackColor(this UISwitch uISwitch)
 		{
 			return uISwitch.GetTrackSubview()?.BackgroundColor;
 		}
+
+		internal static T? FirstOrDefaultNoLinq<T>(this T[] items)


can you move this into ArrayExtensions?

@PureWeen When I move this to ArrayExtensions as is, I get this error: "Error CS0518: Predefined type 'System.Index' is not defined or imported(CS0518) (Core)". I'm not sure why as it appears that this is an error I could get prior to having C#8 but we are in the same project.

I changed the implementation to something that I don't believe is worse, but let me know if there is a better solution to this?

PureWeen · 2023-04-02T21:00:10Z

src/Core/src/Extensions/ArrayExtensions.cs

@@ -64,5 +64,7 @@ public static T[] RemoveAt<T>(this T[] self, int index)
 		/// <param name="self">The array to retrieve the last item from.</param>
 		/// <returns>An object of type <typeparamref name="T"/> that is the last item in the collection.</returns>
 		public static T Last<T>(this T[] self) => self[self.Length - 1];
+
+		internal static T? FirstOrDefaultNoLinq<T>(this T[] items) => items is null || items.Length == 0 ? default : items[0];


@mandel-macaque this look alright to you?

Looks good, but I am surprise the compiler is not printing a warning with nullability enabled saying something like 'items is not set as nullable'. I think we probably want to do something like:

Suggested change

internal static T? FirstOrDefaultNoLinq<T>(this T[] items) => items is null || items.Length == 0 ? default : items[0];

internal static T? FirstOrDefaultNoLinq<T>(this T[]? items) => items is null || items.Length == 0 ? default : items[0];

Right?

Looking at FirstOrDefaults behavior, this sounds like the correct approach :)

espenrl · 2023-06-07T14:32:22Z

@tj-devel709 would love a backport to .NET 7

jfversluis · 2023-09-08T15:16:20Z

Some people requested a backport to net7.

This is functionality that works in Xamarin.Forms and the change seems safe enough. On the other hand, a workaround is available and we're close to .NET 8 where this is already fixed.

TJ Lambert added 3 commits October 17, 2022 17:37

Add a default color to the track in the off position

786613e

Merge remote-tracking branch 'origin/main' into FixSwitchTrackColor

0292d5d

remove unneeded using statement

ee176d7

tj-devel709 changed the title ~~Fix Switch Off Track Color - Fixes #10099~~ Fix Switch Off Track Color - Fixes https://github.com/dotnet/maui/issues/10099 Oct 18, 2022

tj-devel709 changed the title ~~Fix Switch Off Track Color - Fixes https://github.com/dotnet/maui/issues/10099~~ Fix Switch Off Track Color - Fixes #10099 Oct 18, 2022

jsuarezruiz added area-controls-switch Switch t/bug Something isn't working labels Oct 18, 2022

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Oct 18, 2022

mattleibow reviewed Oct 18, 2022

View reviewed changes

src/Core/src/Platform/iOS/SwitchExtensions.cs Outdated Show resolved Hide resolved

TJ Lambert added 2 commits October 20, 2022 11:04

Use UIColor to handle dark mode

8b91c27

remove noise

890ddd5

mandel-macaque reviewed Oct 25, 2022

View reviewed changes

src/Core/src/Platform/iOS/SwitchExtensions.cs Show resolved Hide resolved

mandel-macaque requested changes Oct 25, 2022

View reviewed changes

src/Core/src/Platform/iOS/SwitchExtensions.cs Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into FixSwitchTrackColor

614cc22

hartez previously requested changes Nov 1, 2022

View reviewed changes

src/Core/src/Platform/iOS/SwitchExtensions.cs Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into FixSwitchTrackColor

60ea991

TJ Lambert added 2 commits November 9, 2022 12:16

Add tests and add null checks for getting subviews

47b8af2

add new lines

6bf4edf

tj-devel709 and others added 5 commits November 11, 2022 08:52

Merge branch 'main' into FixSwitchTrackColor

6defdbe

Merge remote-tracking branch 'origin/main' into FixSwitchTrackColor

bf7d903

Move the tests into the iOS Test

feb48a7

remove UIKit on the shared file

11db0f9

- fix checkbox test

dbfb115

PureWeen requested review from hartez, mandel-macaque and mattleibow November 16, 2022 20:07

Auto-format source code

de13bee

tj-devel709 added 2 commits March 29, 2023 16:04

change test name and make color a static var

b2eae95

Merge remote-tracking branch 'TJ/FixSwitchTrackColor' into FixSwitchT…

daf8876

…rackColor

tj-devel709 marked this pull request as ready for review March 29, 2023 21:05

tj-devel709 requested review from mandel-macaque and mattleibow March 29, 2023 21:07

PureWeen requested changes Mar 30, 2023

View reviewed changes

use Manuels NoLink alternative

92bc1f9

PureWeen requested changes Mar 31, 2023

View reviewed changes

move to arrayExtensions and use different implementation

f34cc10

PureWeen reviewed Apr 2, 2023

View reviewed changes

allow param to be null

50fbc8f

PureWeen requested a review from hartez April 3, 2023 15:19

mandel-macaque approved these changes Apr 3, 2023

View reviewed changes

PureWeen approved these changes Apr 3, 2023

View reviewed changes

PureWeen enabled auto-merge (squash) April 3, 2023 16:01

PureWeen merged commit 9e72fbc into dotnet:main Apr 3, 2023

jsuarezruiz mentioned this pull request Apr 10, 2023

Maui : iOS - Switch color doesn't revert on off #14426

Closed

tj-devel709 modified the milestone: 8.0-preview4 May 16, 2023

tj-devel709 mentioned this pull request May 16, 2023

When the OnColor property of Switch is set, it is applied even if when Off on iOS / Mac #15074

Closed

BretJohnson mentioned this pull request May 17, 2023

Changing the UserAppTheme does not change the colours appropriately #7664

Closed

jfversluis added the backport/suggested The PR author or issue review has suggested that the change should be backported. label Sep 8, 2023

github-actions bot locked and limited conversation to collaborators Dec 17, 2023

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

samhouts added the fixed-in-8.0.0-preview.4.8333 Look for this fix in 8.0.0-preview.4.8333! label Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Switch Off Track Color - Fixes #10099 #10758

Fix Switch Off Track Color - Fixes #10099 #10758

tj-devel709 commented Oct 18, 2022 •

edited by samhouts

Loading

tj-devel709 commented Oct 18, 2022

hartez left a comment

tj-devel709 commented Nov 8, 2022

tj-devel709 commented Nov 10, 2022

azure-pipelines bot commented Nov 10, 2022

github-actions bot commented Mar 29, 2023

tj-devel709 commented Mar 29, 2023

PureWeen Mar 30, 2023

mandel-macaque Mar 30, 2023

tj-devel709 Mar 31, 2023

PureWeen Mar 31, 2023

tj-devel709 Mar 31, 2023

PureWeen Apr 2, 2023 •

edited

Loading

mandel-macaque Apr 3, 2023

tj-devel709 Apr 3, 2023

espenrl commented Jun 7, 2023

jfversluis commented Sep 8, 2023

	internal static T? FirstOrDefaultNoLinq<T>(this T[] items) => items is null \|\| items.Length == 0 ? default : items[0];
	internal static T? FirstOrDefaultNoLinq<T>(this T[]? items) => items is null \|\| items.Length == 0 ? default : items[0];

Fix Switch Off Track Color - Fixes #10099 #10758

Fix Switch Off Track Color - Fixes #10099 #10758

Conversation

tj-devel709 commented Oct 18, 2022 • edited by samhouts Loading

Original Incorrect Behavior

Adjusted Behavior

tj-devel709 commented Oct 18, 2022

hartez left a comment

Choose a reason for hiding this comment

tj-devel709 commented Nov 8, 2022

tj-devel709 commented Nov 10, 2022

azure-pipelines bot commented Nov 10, 2022

github-actions bot commented Mar 29, 2023

tj-devel709 commented Mar 29, 2023

PureWeen Mar 30, 2023

Choose a reason for hiding this comment

mandel-macaque Mar 30, 2023

Choose a reason for hiding this comment

tj-devel709 Mar 31, 2023

Choose a reason for hiding this comment

PureWeen Mar 31, 2023

Choose a reason for hiding this comment

tj-devel709 Mar 31, 2023

Choose a reason for hiding this comment

PureWeen Apr 2, 2023 • edited Loading

Choose a reason for hiding this comment

mandel-macaque Apr 3, 2023

Choose a reason for hiding this comment

tj-devel709 Apr 3, 2023

Choose a reason for hiding this comment

espenrl commented Jun 7, 2023

jfversluis commented Sep 8, 2023

tj-devel709 commented Oct 18, 2022 •

edited by samhouts

Loading

PureWeen Apr 2, 2023 •

edited

Loading