x:Array as resource with key crashes app on device launch

[davidortinau]

Description

This works in the iOS simulator and on desktop. The goal is to have an array of data I can reuse by key.

<?xml version="1.0" encoding="UTF-8" ?>
<?xaml-comp compile="true" ?>
<ResourceDictionary 
    xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
    xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml">

    <x:Array Type="{x:Type x:String}" x:Key="CategoriesArray">
        <x:String>Noodles</x:String>
        <x:String>Rice</x:String>
        <x:String>Appetizers</x:String>
        <x:String>Desserts</x:String>
        <x:String>Beverages</x:String>
    </x:Array>

</ResourceDictionary>

This initially was in the Styles.xaml which I split apart for troubleshooting and used merged dictionaries.

That doesn't work on an iOS device. I get an error about the type converter failing.

The below however does work on the ContentPages:

<BindableLayout.ItemsSource>
    <x:Array Type="{x:Type x:String}" >
        <x:String>Noodles</x:String>
        <x:String>Rice</x:String>
        <x:String>Appetizers</x:String>
        <x:String>Desserts</x:String>
        <x:String>Beverages</x:String>
    </x:Array>
</BindableLayout.ItemsSource>

Steps to Reproduce

Add an array with key to your styles, bind to a BindableLayout, and then run on an iOS device.

Version with bug

6.0.486 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

iOS 15

Did you find any workaround?

don't use a resource

Relevant log output

No response

[ghost]

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

[AlexanderEgorov]

maui-ios 7.0.52/7.0.100 SDK 7.0.100
maui-android 7.0.52/7.0.100 SDK 7.0.100

Related issues:

• [iOS] Type x:Double not found in xmlns http://schemas.microsoft.com/winfx/2009/xaml #6070
• [iOS] Type x:Double not found in xmlns http://schemas.microsoft.com/winfx/2009/xaml #5531

        string GetXaml(string resource, string content) {
            return $@"
<ContentPage xmlns=""http://schemas.microsoft.com/dotnet/2021/maui"" xmlns:x=""http://schemas.microsoft.com/winfx/2009/xaml"">
    <ContentPage.Resources>
        {resource}
    </ContentPage.Resources>
    {content}
</ContentPage>";
        }

        //Throws a XamlParseException on real device (iOS and Android) when app is build in Release configuration 
        //Works fine in Debug configuration or on simulators.
        [Test]
        public async Task LoadXamlTest1() {
            var xaml = GetXaml(
                @"<x:String x:Key=""text"">TEST</x:String>",
                @"<Button Text=""{StaticResource text}""/>");
            var cp = new ContentPage().LoadFromXaml(xaml);
            var bt = (Button)cp.Content;
            Assert.AreEqual("TEST", bt.Text);
        }

        //Throws a XamlParseException on real device (iOS and Android) when app is build in Release configuration 
        //Works fine in Debug configuration or on simulators.
        [Test]
        public async Task LoadXamlTest2() {
            var xaml = GetXaml(
                @"<x:Double x:Key=""borderWidth"">3</x:Double>",
                @"<Button BorderWidth=""{StaticResource borderWidth}""/>");
            var cp = new ContentPage().LoadFromXaml(xaml);
            var bt = (Button)cp.Content;
            Assert.AreEqual(3, bt.BorderWidth);
        }

        //Throws a XamlParseException on real device (iOS and Android) when app is build in Release configuration 
        //Works fine in Debug configuration or on simulators. 
        [Test]
        public async Task LoadXamlTest3() {
            var xaml = GetXaml(
                @"<x:Int32 x:Key=""borderWidth"">3</x:Int32>",
                @"<Button CornerRadius=""{StaticResource borderWidth}""/>");
            var cp = new ContentPage().LoadFromXaml(xaml);
            var bt = (Button)cp.Content;
            Assert.AreEqual(3, bt.CornerRadius);
        }

         //Works file
        [Test]
        public async Task LoadXamlTest4() {
            var xaml = GetXaml(
                @"<Color x:Key=""borderColor"">#FF0000</Color>",
                @"<Button BorderColor=""{StaticResource borderColor}""/>");
            var cp = new ContentPage().LoadFromXaml(xaml);
            var bt = (Button)cp.Content;
            Assert.AreEqual(Colors.Red, bt.BorderColor);
        }
         //Works file
        [Test]
        public async Task LoadXamlTest5() {
            var xaml = GetXaml(
                @"<Thickness x:Key=""margin"">4</Thickness>",
                @"<Button Margin=""{StaticResource margin}""/>");
            var cp = new ContentPage().LoadFromXaml(xaml);
            var bt = (Button)cp.Content;
            Assert.AreEqual(new Thickness(4), bt.Margin);
        }
         //Works file
        [Test]
        public async Task LoadXamlTest6() {
            var xaml = GetXaml(
                @"<FontAttributes x:Key=""fontAttributes"">Italic</FontAttributes>",
                @"<Button FontAttributes=""{StaticResource fontAttributes}""/>");
            var cp = new ContentPage().LoadFromXaml(xaml);
            var bt = (Button)cp.Content;
            Assert.AreEqual(FontAttributes.Italic, bt.FontAttributes);
        }
         //Works file
        [Test]
        public async Task LoadXamlTest7() {
            var xaml = GetXaml(
                @"<x:Array x:Key=""source"" Type=""{x:Type Color}"">
                    <Color>#FF0000</Color>
                </x:Array>",
                @"<ListView ItemsSource=""{StaticResource source}"" />");
            var cp = new ContentPage().LoadFromXaml(xaml);
            var l = (ListView)cp.Content;
            Assert.AreEqual(1, l.ItemsSource.OfType<object>().Count());
        }

[vhugogarcia]

Hello friends,

I just wanted to share that this issue is still happening and it forced me to remove any reference to x:Double and x:String on my styles resource dictionary, so I could be able to run the application on DEBUG mode + Link SDK Assemblies only selected on iOS, just to figure out an issue on release mode only was facing. ;)

Visual Studio Community 2022 for Mac
Version 17.4.3 (build 21)
maui-ios 7.0.58/7.0.100 SDK 7.0.100

If you need anything from me =), please let me know I will be happy to share anything you need to reproduce the issue, however our friend @davidortinau I believe he explained it very simple and how to reproduce it.

Thanks for the help with this and anything related with .NET MAUI 👍🏻. Really appreciate it.

[Nibby]

I can also attest that this issue is still happening. On a blank MAUI template project, adding x:String entries to the Styles.xaml resource dictionary causes the app to crash when it is deployed to a device (iOS and Android). Interestingly, it only occurs when <MtouchLink> is set to SdkOnly in the csproj file. If it is set to None, the problem goes away.

This is a serious blocker to a project I am working on.

My workload version are as follows:

Installed Workload Id      Manifest Version       Installation Source
---------------------------------------------------------------------
wasm-tools                 7.0.2/7.0.100          SDK 7.0.100        
macos                      13.1.1007/7.0.100      SDK 7.0.100        
maui-maccatalyst           7.0.59/7.0.100         SDK 7.0.100        
maui-ios                   7.0.59/7.0.100         SDK 7.0.100        
maui-android               7.0.59/7.0.100         SDK 7.0.100        
ios                        16.2.1007/7.0.100      SDK 7.0.100        
maccatalyst                16.2.1007/7.0.100      SDK 7.0.100        
maui                       7.0.59/7.0.100         SDK 7.0.100        
android                    33.0.26/7.0.100        SDK 7.0.100   

Hope this issue can be fixed in the near future.

[Eskissimo]

Hi,

The issue happens also when we publish Android app with AOT enable.

Regards.

[JonnySKK]

We are still encountering this issue with both x:String and x:Double in Release mode on Android & iOS

[jonathanpeppers]

I can repro this in Release mode (but works fine Debug):

One thing to note is that compiled .xaml appears to work fine for me. So, you can use XamlCompilation for now, and avoid things like LoadFromXaml("your xaml string")?

[vhugogarcia]

Hello @jonathanpeppers ,

Thanks for looking into this issue.

It is also easy to reproduce it on DEBUG mode. Just enable: Link SDKs frameworks only and try it. 😎👍🏻

If there is anything else I can do to reproduce the issue let me know. I am happy to help 👍🏻🙂

[jonathanpeppers]

@vhugogarcia is there a reason you're not using compiled XAML?

From my testing, the defaults work:

• Debug mode works: parsed xaml + no trimming
• Release mode works: compiled xaml + trimming

The only place you hit this issue is trimming + parsed xaml.

[jonathanpeppers]

Note that I only tried Android so far, perhaps this fails on iOS with Debug defaults?

[vhugogarcia]

Note that I only tried Android so far, perhaps this fails on iOS with Debug defaults?

You are partially correct @jonathanpeppers . When you set DEBUG mode and set Link SDK Assemblies only it fails as well for iOS emulators or physical devices.

I'm sharing here a repository in case you need it. https://github.com/vhugogarcia/MauiStylesDemo

[jonathanpeppers]

Link SDK Assemblies only

But you had to turn this on for iOS? It wasn't the default setting?

[vhugogarcia]

Yes, I had to set Link SDK Assemblies only setting on DEBUG mode, because I faced an issue when the app was in the stores and several clients reported unexpected crash of the app and I was unable to reproduce the issue because when I debug locally simulators or physical devices the Linker is set to NONE, which works fine for development.

However, in order for me to reproduce the issue the customers and users are facing I have to mimic the release mode but with the ability to set breakpoints on VS for macOS.

[jonathanpeppers]

So, you'd probably want to also enable <MauiXamlCValidateOnly>false</MauiXamlCValidateOnly> if you are testing in this way:

maui/src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.targets

Lines 150 to 151 in 13e66e0

	<_MauiXamlCValidateOnly>$(MauiXamlCValidateOnly)</_MauiXamlCValidateOnly>
	<_MauiXamlCValidateOnly Condition="'$(Configuration)' != 'Release' AND '$(_MauiForceXamlCForDebug)' != 'True'">True</_MauiXamlCValidateOnly>

[vhugogarcia]

So, you'd probably want to also enable <MauiXamlCValidateOnly>false</MauiXamlCValidateOnly> if you are testing in this way:

maui/src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.targets

Lines 150 to 151 in 13e66e0

	<_MauiXamlCValidateOnly>$(MauiXamlCValidateOnly)</_MauiXamlCValidateOnly>
	<_MauiXamlCValidateOnly Condition="'$(Configuration)' != 'Release' AND '$(_MauiForceXamlCForDebug)' != 'True'">True</_MauiXamlCValidateOnly>

I tried adding those and they did not work @jonathanpeppers . See screenshot below. Even adding those settings on the .csproj file

[jonathanpeppers]

No, you put <MauiXamlCValidateOnly>false</MauiXamlCValidateOnly> in your project.

You can verify by watching an MSBuild log to see if the XamlCTask runs or not.

[jonathanpeppers]

Actually, I'm reading it wrong, it would be <_MauiForceXamlCForDebug>true</_MauiForceXamlCForDebug>.

I'm not a fan of the MSBuild logic here... It might be something I can fix for them.

[vhugogarcia]

Thanks @jonathanpeppers for the feedback. I remember I tried that in the past without luck. However, I tried it again just to double check and this is the result. It worked OK 👍🏻 .

So the results are below (iOS):

Using <_MauiForceXamlCForDebug>true</_MauiForceXamlCForDebug> in the .csproj file

• DEBUG + Linker None = Error
• DEBUG + Linker SDK Assemblies Only = OK
• DEBUG + Linker All = OK

Not using <_MauiForceXamlCForDebug>true</_MauiForceXamlCForDebug> in the .csproj file

• DEBUG + Linker None = OK
• DEBUG + Linker SDK Assemblies Only = Error
• DEBUG + Linker All = Error (Position 9:37. Cannot assign property "Source": Property does not exist, or is not assignable, or mismatching type between value and property)

So, what makes this interesting is why I should add that property in the .csproj file if I'm already declaring this on the Styles.xaml file