Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Windows) RC1 - RefreshView does not appear when swiping down with mouse #6404

Closed
1 task
Sergtek opened this issue Apr 22, 2022 · 10 comments
Closed
1 task
Labels
area-controls-refreshview RefreshView blocked Work that is currently blocked external fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! p/2 Work that is important, but is currently not scheduled for release partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with partner/winui WinUI / Project Reunion platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working

Comments

@Sergtek
Copy link

Sergtek commented Apr 22, 2022

Description

In Windows the RefreshView does not appear when you swipe down with the mouse, however in Android it does, as can be seen in this image:

Issue07

Repository:
https://github.com/nacompllo/MauiCollectionView/tree/test/WindowsRefreshView

Steps to Reproduce

Cloning the attached repository and trying to Swipe down on the CollectionView on Windows the RefreshView will not appear.

Version with bug

Release Candidate 1 (current)

Last version that worked well

Unknown/Other

Affected platforms

Windows, I was not able test on other platforms

Affected platform versions

Windows 11

Did you find any workaround?

No response

Relevant log output

No response

Depends on

VS bug #1779664

@Sergtek Sergtek added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels Apr 22, 2022
@Sergtek Sergtek changed the title (Windows) RC1 - RefreshView does not appear when swiping down (Windows) RC1 - RefreshView does not appear when swiping down with mouse Apr 22, 2022
@v-longmin v-longmin added s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Apr 22, 2022
@v-longmin
Copy link

Verified repro on windows & Android with VS 17.3.0 Preview 1.0 [32414.199.main].Repro project:
MauiCollectionView-test-WindowsRefreshView.zip

@Redth Redth added legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor platform/windows 🪟 labels Apr 25, 2022
@Redth Redth added this to the 6.0.300 milestone Apr 26, 2022
@davidortinau davidortinau added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label May 1, 2022
@Redth Redth added p/2 Work that is important, but is currently not scheduled for release and removed p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint labels May 3, 2022
@samhouts
Copy link
Member

samhouts commented May 5, 2022

This is another symptom of the root cause of #6152, which is basically that the mouse drag events are not captured. The swipe does work with touch.

@ghost
Copy link

ghost commented Aug 30, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@taublast
Copy link
Contributor

Any official guideline on how to use the RefreshView on windows for users with mice?

@shivagurunatha
Copy link

In Windows I couldn't able to see the refresh icon on both swiping and dragging with mouse.
Visual studio version - 17.5.0 Preview 1.0.
Any workaround suggestions please?

@shivagurunatha
Copy link

In Windows I couldn't able to see the refresh icon on both swiping and dragging with mouse. Visual studio version - 17.5.0 Preview 1.0. Any workaround suggestions please?

As of now I had resolved it with a Handler. Not so best but convincing so far now.

 public class CustomRefreshViewHandler : RefreshViewHandler
  {
    public CustomRefreshViewHandler()
    {

    }

    protected override void ConnectHandler(RefreshContainer nativeView)
    {
        if (PlatformView != null)
        {
            PlatformView.ManipulationMode = Microsoft.UI.Xaml.Input.ManipulationModes.All;
            PlatformView.ManipulationDelta += PlatformView_ManipulationDelta;
        }

        base.ConnectHandler(nativeView);
    }

    protected override void DisconnectHandler(RefreshContainer nativeView)
    {
        if (PlatformView != null)
        {
            PlatformView.ManipulationDelta -= PlatformView_ManipulationDelta;
        }

        base.DisconnectHandler(nativeView);
    }

    private void PlatformView_ManipulationDelta(object sender, Microsoft.UI.Xaml.Input.ManipulationDeltaRoutedEventArgs e)
    {
        double cumulativeY = e.Cumulative.Translation.Y;
        if (cumulativeY > 100)
        {
            if (!VirtualView.IsRefreshing)
            {
                VirtualView.IsRefreshing = true;
            }
        }
    }
} 

@danardelean
Copy link

This issue was opened almost a year ago and it is still not fixed On Windows if you use the mouse the RefreshView is not usable You cannot fire the event

@samhouts samhouts added partner/winui WinUI / Project Reunion blocked Work that is currently blocked area-controls-refreshview RefreshView external partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with labels Mar 27, 2023
@jsuarezruiz jsuarezruiz self-assigned this Mar 28, 2023
@Markodirtyboy
Copy link

Any updates to the workaround?

@jsuarezruiz jsuarezruiz moved this to In Progress in MAUI SDK Ongoing Mar 29, 2023
rmarinho pushed a commit that referenced this issue Mar 30, 2023
…ixes #6404

* Allow to refresh using the mouse on Windows

* Updated minimumCumulativeY
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Mar 30, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Apr 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
@samhouts samhouts removed blocked Work that is currently blocked external labels May 22, 2023
@samhouts samhouts modified the milestones: Backlog, .NET 8 May 22, 2023
@samhouts samhouts added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Jun 21, 2023
@jsuarezruiz
Copy link
Contributor

This issue have been fixed by https://github.com/dotnet/maui/pull/14261/files

@hartez
Copy link
Contributor

hartez commented Jul 12, 2023

From the design guidelines for Windows UI: "RefreshContainer works only with touch, so we recommend that you also have a refresh button available for users who don't have a touch interface. You can position the refresh button at a suitable location in the app, either on a command bar or at a location close to the surface being refreshed."

The control is not designed to work with a mouse pointer; if you're building a desktop application with the intent of using mouse input, you should provide an appropriate refresh mechanism.

@samhouts samhouts added blocked Work that is currently blocked external labels Jul 24, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@PureWeen PureWeen removed the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-refreshview RefreshView blocked Work that is currently blocked external fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! p/2 Work that is important, but is currently not scheduled for release partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with partner/winui WinUI / Project Reunion platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests