Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dismissing iOS Modal Form Page causes NRE #2948

Closed
drasticactions opened this issue Oct 14, 2021 · 6 comments · Fixed by #5566
Closed

[Bug] Dismissing iOS Modal Form Page causes NRE #2948

drasticactions opened this issue Oct 14, 2021 · 6 comments · Fixed by #5566
Assignees
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! good first issue Good for newcomers s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@drasticactions
Copy link
Contributor

MAUI build 6.0.101-preview.10.1858

Crash.mp4

If you use the iOS Form Modal Page and dismiss it, you get an NRE.

   at Microsoft.Maui.Controls.Platform.ModalWrapper.DidDismiss(UIPresentationController presentationController)
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__127_0(Object state)
   at Foundation.NSAsyncSynchronizationContextDispatcher.Apply()
--- End of stack trace from previous location ---
   at UIKit.UIApplication.Main(String[] args, Type principalClass, Type delegateClass)
   at MauiVirtManager.Program.Main(String[] args) in C:\Users\t_mil\source\repos\Work\Hackathon\MauiVirtManager\MauiVirtManager\Platforms\iOS\Program.cs:line 12
@jsuarezruiz jsuarezruiz added the t/bug Something isn't working label Oct 22, 2021
@hartez hartez added the area-navigation NavigationPage label Nov 5, 2021
@PureWeen PureWeen added area-controls-shell Shell Navigation, Routes, Tabs, Flyout and removed area-navigation NavigationPage labels Nov 12, 2021
@PureWeen PureWeen self-assigned this Nov 12, 2021
@hartez hartez added the fatal label Jan 5, 2022
@kristinx0211
Copy link

@drasticactions can you share the repro project for this issue.

@PureWeen PureWeen removed their assignment Mar 4, 2022
@PureWeen PureWeen added the good first issue Good for newcomers label Mar 4, 2022
@v-longmin
Copy link

@drasticactions Could you share the repro project for this issue, thanks?

@v-longmin v-longmin added s/triaged Issue has been reviewed s/needs-info Issue needs more info from the author labels Mar 9, 2022
@ghost
Copy link

ghost commented Mar 9, 2022

Hi @drasticactions. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@ghost ghost added the s/no-recent-activity Issue has had no recent activity label Mar 14, 2022
@ghost
Copy link

ghost commented Mar 14, 2022

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. If it is closed, feel free to comment when you are able to provide the additional information and we will re-investigate.

@J-Swift
Copy link
Contributor

J-Swift commented Mar 14, 2022

You can repro this on the modal page of the Control.Sample app

@ghost ghost added s/needs-attention Issue has more information and needs another look and removed s/needs-info Issue needs more info from the author s/no-recent-activity Issue has had no recent activity labels Mar 14, 2022
@Redth
Copy link
Member

Redth commented Mar 23, 2022

Still repro's for a FlyoutPage (but not regular page or navigation page) on main.

@Redth Redth removed fatal s/needs-attention Issue has more information and needs another look labels Mar 23, 2022
@Redth Redth added this to the 6.0.300 milestone Mar 23, 2022
@kristinx0211 kristinx0211 added the s/verified Verified / Reproducible Issue ready for Engineering Triage label Mar 24, 2022
mkhamoyan added a commit to mkhamoyan/maui that referenced this issue Mar 25, 2022
PureWeen added a commit that referenced this issue Mar 25, 2022
* #2948 changed RootViewController , in case of FlyoutPage view.Window was null

* - add Tests

* - fix tests

* - fix android tests

* Update ModalNavigationManager.Android.cs

Co-authored-by: Shane Neuville <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2022
@samhouts samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! good first issue Good for newcomers s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants