Flyout page in Android does not show flyout button (burger) consistently

[guyvaio]

Description

The condition to show the flyout button (burger) or not is set in method ShouldShowToolbarButton of the FlyoutPage.
In Android, this method is not hit when orientation changes. This method is only called once during initialization.
Test is done with a physical Android tablet running MAUI 8.0.90-dev.

Under iOS, rotation of an iPad triggers correctly method ShouldShowToolbarButton.

The default code of ShouldShowToolbarButton of depends on the orientation. It’s inconsistent not to trigger this code after rotation.

public virtual bool ShouldShowToolbarButton()
{
	if (DeviceInfo.Idiom == DeviceIdiom.Phone)
		return true;

	FlyoutLayoutBehavior behavior = FlyoutLayoutBehavior;
	var orientation = DeviceDisplay.MainDisplayInfo.Orientation;

	bool isSplitOnLandscape = (behavior == FlyoutLayoutBehavior.SplitOnLandscape || behavior == FlyoutLayoutBehavior.Default) && orientation.IsLandscape();
	bool isSplitOnPortrait = behavior == FlyoutLayoutBehavior.SplitOnPortrait && orientation.IsPortrait();
	return behavior != FlyoutLayoutBehavior.Split && !isSplitOnLandscape && !isSplitOnPortrait;
}

Steps to Reproduce

1. Create an MAUI app for MAUI 8.0
2. For simplification purposes, set TargetFrameworks to net8.0-android only
3. Set a FlyoutPage as the MainPage
4. Set a simple ContentPage as Flyout of the MainPage
5. Set a NavigationPage as Detail of the MainPage

Link to public reproduction project repository

No response

Version with bug

8.0.80 SR8

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 12.0

Did you find any workaround?

Modification of source code in Maui-main\src\Controls\src\Core\NavigationPage\NavigationPageToolbar.cs

Relevant log output

No response

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

• FlyoutPage's menu icon not showing, when used in a NavigationPage on Android (#22116), similarity score: 0.79
• FlyoutPage inside a NavigationPage causes different behavior between Android and iOS (#18228), similarity score: 0.79

Closed similar issues:

• FlyoutIsPresented is not working on Android (#20779), similarity score: 0.81
• ShouldShowToolbarButton() override on FlyoutPage not working (#15111), similarity score: 0.80
• Android FlyoutPage does not display navigation bar NET 8 (#19623), similarity score: 0.78

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[guyvaio]

Temporary fix https://gist.github.com/guyvaio/5ca11a6aa373c1fe486cc9e25137aeec
Hope this helps others.