Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BindableLayout performance could be better #23135

Closed
albyrock87 opened this issue Jun 19, 2024 · 3 comments · Fixed by #23136
Closed

BindableLayout performance could be better #23135

albyrock87 opened this issue Jun 19, 2024 · 3 comments · Fixed by #23136
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView delighter-sc fixed-in-8.0.90 fixed-in-9.0.0-rc.2.24503.2 p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 t/bug Something isn't working
Milestone

Comments

@albyrock87
Copy link
Contributor

Description

I have a custom calendar view which can switch between month-view and week-view.
Days are rendered through CommunityToolkit UniformLayout by leveraging BindableLayout.
Now, when you switch from one month to another the BindableLayout basically removes all the children and recreates them.

The performance here is definitely poor and could be improved a lot by reusing already generated views when template can be reused and simply change the BindingContext.

Steps to Reproduce

No response

Link to public reproduction project repository

No response

Version with bug

8.0.60 SR6

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android, Windows, macOS, Other (Tizen, Linux, etc. not supported by Microsoft directly)

Affected platform versions

No response

Did you find any workaround?

No workaround possible besides creating my own BindableLayout version.

Relevant log output

No response

@albyrock87 albyrock87 added the t/bug Something isn't working label Jun 19, 2024
Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

albyrock87 added a commit to albyrock87/maui that referenced this issue Jun 19, 2024
@PureWeen PureWeen added p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Jun 19, 2024
@PureWeen PureWeen added this to the .NET 8 SR8 milestone Jun 19, 2024
@MartyIX
Copy link
Contributor

MartyIX commented Jun 20, 2024

@albyrock87 Could you share what performance improvement you observe? I'm just curious.

@albyrock87
Copy link
Contributor Author

@MartyIX look at my PR, there are animated gifs in the description which shows exactly what I'm talking about!
Consider those videos are recorded on an M3 PRO (which is super fast usually).

@PureWeen PureWeen modified the milestones: .NET 8 SR8, .NET 8 SR9 Aug 2, 2024
@PureWeen PureWeen moved this from In Progress to Ready To Review in MAUI SDK Ongoing Aug 12, 2024
github-actions bot pushed a commit to albyrock87/maui that referenced this issue Aug 16, 2024
github-actions bot pushed a commit to albyrock87/maui that referenced this issue Sep 5, 2024
@github-project-automation github-project-automation bot moved this from Ready To Review to Done in MAUI SDK Ongoing Sep 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView delighter-sc fixed-in-8.0.90 fixed-in-9.0.0-rc.2.24503.2 p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 t/bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants