Skip to content

Commit

Permalink
Set CanDrag and AllowDrop only if needed (#22640)
Browse files Browse the repository at this point in the history
  • Loading branch information
MartyIX authored Jun 4, 2024
1 parent 5d3e788 commit 6d4d7bd
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ void ClearContainerEventHandlers()
{
_subscriptionFlags &= ~SubscriptionFlags.ContainerDragEventsSubscribed;

_container.CanDrag = false;
_container.DragStarting -= HandleDragStarting;
_container.DropCompleted -= HandleDropCompleted;
}
Expand All @@ -323,6 +324,7 @@ void ClearContainerEventHandlers()
{
_subscriptionFlags &= ~SubscriptionFlags.ContainerDropEventsSubscribed;

_container.AllowDrop = false;
_container.DragOver -= HandleDragOver;
_container.Drop -= HandleDrop;
_container.DragLeave -= HandleDragLeave;
Expand Down Expand Up @@ -719,15 +721,13 @@ void UpdateDragAndDropGestureRecognizers()
}

bool canDrag = gestures.FirstGestureOrDefault<DragGestureRecognizer>()?.CanDrag ?? false;
_container.CanDrag = canDrag;

bool allowDrop = gestures.FirstGestureOrDefault<DropGestureRecognizer>()?.AllowDrop ?? false;
_container.AllowDrop = allowDrop;

if (canDrag)
{
_subscriptionFlags |= SubscriptionFlags.ContainerDragEventsSubscribed;

_container.CanDrag = true;
_container.DragStarting += HandleDragStarting;
_container.DropCompleted += HandleDropCompleted;
}
Expand All @@ -736,6 +736,7 @@ void UpdateDragAndDropGestureRecognizers()
{
_subscriptionFlags |= SubscriptionFlags.ContainerDropEventsSubscribed;

_container.AllowDrop = true;
_container.DragOver += HandleDragOver;
_container.Drop += HandleDrop;
_container.DragLeave += HandleDragLeave;
Expand Down

0 comments on commit 6d4d7bd

Please sign in to comment.