[iOS/MacCatalyst] Fix SearchBar TextChanged event not working issue (#…

…5462) * Fix SearchBar TextChanged event not working on iOS/Catalyst * Removed SetupDefaults Co-authored-by: Rui Marinho <[email protected]>
dotnet · Mar 30, 2022 · 43547cb · 43547cb
1 parent 2288eea
commit 43547cb
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 2 deletions.
diff --git a/src/Controls/samples/Controls.Sample/Pages/Controls/SearchBarPage.xaml b/src/Controls/samples/Controls.Sample/Pages/Controls/SearchBarPage.xaml
@@ -73,6 +73,11 @@
                     Style="{StaticResource Headline}"/>
                 <SearchBar
                     IsTextPredictionEnabled="False"/>
+                <Label
+                    Text="TextChanged"
+                    Style="{StaticResource Headline}"/>
+                <SearchBar
+                    TextChanged="OnSearchBarTextChanged"/>
                 <Label
                     Text="Background color"
                     Style="{StaticResource Headline}"/>

diff --git a/src/Controls/samples/Controls.Sample/Pages/Controls/SearchBarPage.xaml.cs b/src/Controls/samples/Controls.Sample/Pages/Controls/SearchBarPage.xaml.cs
@@ -1,10 +1,19 @@
-namespace Maui.Controls.Sample.Pages
+using System.Diagnostics;
+using Microsoft.Maui.Controls;
+
+namespace Maui.Controls.Sample.Pages
 {
 	public partial class SearchBarPage
 	{
 		public SearchBarPage()
 		{
 			InitializeComponent();
 		}
+
+		void OnSearchBarTextChanged(object sender, TextChangedEventArgs args)
+		{
+			var text = ((SearchBar)sender).Text;
+			Debug.WriteLine($"SearchBar Text changed: {text}");
+		}
 	}
 }
diff --git a/src/Core/src/Handlers/SearchBar/SearchBarHandler.iOS.cs b/src/Core/src/Handlers/SearchBar/SearchBarHandler.iOS.cs
@@ -31,7 +31,10 @@ protected override void ConnectHandler(MauiSearchBar platformView)
 
 			platformView.OnEditingStarted += OnEditingStarted;
 			platformView.OnEditingStopped += OnEditingEnded;
-
+
+			if (_editor != null)
+				_editor.EditingChanged += OnEditingChanged;
+
 			base.ConnectHandler(platformView);
 		}
 
@@ -45,6 +48,8 @@ protected override void DisconnectHandler(MauiSearchBar platformView)
 			platformView.OnEditingStarted -= OnEditingStarted;
 			platformView.OnEditingStopped -= OnEditingEnded;
 
+			if (_editor != null)
+				_editor.EditingChanged -= OnEditingChanged;
 
 			base.DisconnectHandler(platformView);
 		}
@@ -171,5 +176,13 @@ void OnEditingStarted(object? sender, EventArgs e)
 			if (VirtualView != null)
 				VirtualView.IsFocused = true;
 		}
+
+		void OnEditingChanged(object? sender, EventArgs e)
+		{
+			if (VirtualView == null || _editor == null)
+				return;
+
+			VirtualView.UpdateText(_editor.Text);
+		}
 	}
 }