Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass DotNetFinalVersionKind via yaml as a global property #168

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
<PropertyGroup>
<PreReleaseVersionLabel>rtm</PreReleaseVersionLabel>
<PreReleaseVersionIteration></PreReleaseVersionIteration>
<!-- Enables removing prerelease labels. -->
<DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<!-- Opt-out repo features -->
<UseVSTestRunner>true</UseVSTestRunner>
<UsingToolXliff>false</UsingToolXliff>
Expand Down
5 changes: 5 additions & 0 deletions eng/pipelines/maintenance-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,15 @@ extends:
fetchDepth: 0
clean: true
steps:
# Manually run an Azure DevOps job with the variable 'DotNetFinalVersionKind' set to 'release' to
# generate a stable version (package names without preview suffix strings).
# For nightly builds this value should be empty (default value).
# https://github.com/dotnet/arcade/blob/master/Documentation/CorePackages/Versioning.md#package-versioning
- script: eng\common\cibuild.cmd
-configuration Release
-prepareMachine
/p:Test=false
/p:DotNetFinalVersionKind=$(DotNetFinalVersionKind)
$(_AdditionalBuildArgs)
$(_InternalBuildArgs)
displayName: $(_BuildJobDisplayName)
Expand Down