Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for building with NetCurrent (net8.0) #149

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add support for building with NetCurrent (net8.0) #149

merged 3 commits into from
Oct 31, 2024

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Oct 30, 2024 •
edited
Loading

This is first step to addressing #125

  • Additionally, added a missing test resource file.

ViktorHofer
ViktorHofer approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a target that reminds us to remove NetCurrent again when NetMinimum gets updated to net8.0. I also reordered the TFMs so that NetCurrent-windows gets built by default in VS.

@ViktorHofer ViktorHofer enabled auto-merge (squash) October 31, 2024 07:29
@ViktorHofer ViktorHofer merged commit b092e93 into main Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@ericstj ericstj Awaiting requested review from ericstj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheenamalhotra @ViktorHofer