[msbuild] Don't use storyboards / asset catalogs in the prebuilt HotRestart app bundle. #21237
Conversation
…estart app bundle. Use the Info.plist to set the launch image and app icons for the app, instead of using a storyboard / asset catalog. One minor change is that the ".NET" text in the launch image is not located in exactly the same place anymore. This is because it was rather complicated to get the background color of the launch image correct. I tried numerous options, neither of them fully work: * Set the background color in the launch sreen png itself: this will create black or white borders around the image. * Use svg: svg doesn't work. * There doesn't seem to be a way o specify multiple launch screen images, and have iOS pick the best one depending on the target device size. The end solution was to provide a really big launch screen png, so that there won't be any black or white border on any of today's devices. The downside is, as mentioned, that the text is not located in the same place once iOS has adjusted the size of the image to fit the current device. The big advantage is that this means we won't need to install the iOS simulator on CI during our product build, we only need Xcode itself (we'll still need all the simulators for our tests).
This comment has been minimized.
This comment has been minimized.
📚 [CI Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent |
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 97 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Use the Info.plist to set the launch image and app icons for the app, instead
of using a storyboard / asset catalog.
One minor change is that the ".NET" text in the launch image is not located in
exactly the same place anymore. This is because it was rather complicated to
get the background color of the launch image correct. I tried numerous
options, neither of them fully work:
black or white borders around the image.
have iOS pick the best one depending on the target device size.
The end solution was to provide a really big launch screen png, so that there
won't be any black or white border on any of today's devices. The downside is,
as mentioned, that the text is not located in the same place once iOS has
adjusted the size of the image to fit the current device.
The big advantage is that this means we won't need to install the iOS
simulator on CI during our product build, we only need Xcode itself (we'll
still need all the simulators for our tests).
iPhone launch screen:
iPad launch screen: