-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MetalPerforanceShadersGraph] Implement Xcode 16.0 beta 1-6 changes. #21154
Merged
rolfbjarne
merged 5 commits into
xcode16
from
dev/rolf/xcode16-b1-metalperformanceshadersgraph
Sep 5, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
63a4a9c
[MetalPerforanceShadersGraph] Implement Xcode 16.0 beta 1-6 changes.
rolfbjarne 086f497
Auto-format source code
06bbda6
[introspection] Fix a few issues.
rolfbjarne 843ce04
Merge remote-tracking branch 'origin/xcode16' into dev/rolf/xcode16-b…
rolfbjarne f1aafd0
Fix introspection.
rolfbjarne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
#nullable enable | ||
|
||
using System; | ||
using System.Buffers; | ||
using System.Runtime.InteropServices; | ||
|
||
using Foundation; | ||
using ObjCRuntime; | ||
using Metal; | ||
using MetalPerformanceShaders; | ||
|
||
namespace MetalPerformanceShadersGraph { | ||
/// <summary>This enum is used to select how to initialize a new instance of a <see cref="MPSGraphExecutable" />.</summary> | ||
#if NET | ||
[SupportedOSPlatform ("ios17.0")] | ||
[SupportedOSPlatform ("maccatalyst17.0")] | ||
[SupportedOSPlatform ("macos14.0")] | ||
[SupportedOSPlatform ("tvos17.0")] | ||
#else | ||
[TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||
#endif | ||
public enum MPSGraphExecutableInitializationOption { | ||
/// <summary>The <c>packageUrl</c> parameter passed to the constructor is a url to a CoreML package.</summary> | ||
#if NET | ||
[SupportedOSPlatform ("ios18.0")] | ||
[SupportedOSPlatform ("maccatalyst18.0")] | ||
[SupportedOSPlatform ("macos15.0")] | ||
[SupportedOSPlatform ("tvos18.0")] | ||
#else | ||
[TV (18, 0), Mac (15, 0), iOS (18, 0), MacCatalyst (18, 0)] | ||
#endif | ||
CoreMLPackage, | ||
|
||
/// <summary>The <c>packageUrl</c> parameter passed to the constructor is a url to a MPSGraph package.</summary> | ||
MPSGraphPackage, | ||
} | ||
|
||
public partial class MPSGraphExecutable { | ||
/// <summary>Create a new MPSGraphExecutable instance from a package url and a compilation descriptor..</summary> | ||
/// <param name="packageUrl">The url to the package to use.</param> | ||
/// <param name="compilationDescriptor">The optional compilation descriptor use.</param> | ||
/// <param name="option">Use this option to specify whether the package url points to a CoreML package or an MPSGraph package.</param> | ||
#if NET | ||
[SupportedOSPlatform ("ios17.0")] | ||
[SupportedOSPlatform ("maccatalyst17.0")] | ||
[SupportedOSPlatform ("macos14.0")] | ||
[SupportedOSPlatform ("tvos17.0")] | ||
#else | ||
[TV (17, 0), Mac (14, 0), iOS (17, 0), MacCatalyst (17, 0)] | ||
#endif | ||
public MPSGraphExecutable (NSUrl packageUrl, MPSGraphCompilationDescriptor? compilationDescriptor, MPSGraphExecutableInitializationOption option) | ||
: base (NSObjectFlag.Empty) | ||
{ | ||
switch (option) { | ||
case MPSGraphExecutableInitializationOption.CoreMLPackage: | ||
InitializeHandle (_InitWithCoreMLPackage (packageUrl, compilationDescriptor)); | ||
break; | ||
case MPSGraphExecutableInitializationOption.MPSGraphPackage: | ||
InitializeHandle (_InitWithMPSGraphPackage (packageUrl, compilationDescriptor)); | ||
break; | ||
default: | ||
throw new ArgumentOutOfRangeException (nameof (option), option, "Invalid enum value."); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into creating a unit test for this constructor, but it turns out that in order to create a package to load, you have to create an MPSGraph that actually works, which is quite complex if you don't know how to use the API.