Skip to content

Commit

Permalink
[Harness] Fix some typos. (#9303)
Browse files Browse the repository at this point in the history
  • Loading branch information
@mandel-macaque
mandel-macaque authored Aug 6, 2020
1 parent 90bf04f commit f147fe9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/BuildProject.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
namespace Microsoft.DotNet.XHarness.iOS.Shared.Tasks {
public class BuildProject : BuildTool {
public IResourceManager ResourceManager { get; set; }
public IEnvManager EnviromentManager { get; set; }
public IEnvManager EnvironmentManager { get; set; }
public IEventLogger EventLogger { get; set; }
Func<string> msbuildPath;

Expand All @@ -22,7 +22,7 @@ public BuildProject (Func<string> msbuildPath, IProcessManager processManager, I
this.msbuildPath = msbuildPath ?? throw new ArgumentNullException (nameof (msbuildPath));
ResourceManager = resourceManager ?? throw new ArgumentNullException (nameof (resourceManager));
EventLogger = eventLogger ?? throw new ArgumentNullException (nameof (eventLogger));
EnviromentManager = envManager ?? throw new ArgumentNullException (nameof (envManager));
EnvironmentManager = envManager ?? throw new ArgumentNullException (nameof (envManager));
}

public bool RestoreNugets {
Expand Down Expand Up @@ -58,7 +58,7 @@ async Task<TestExecutingResult> RestoreNugetsAsync (string projectPath, ILog log
args.Add ("-Verbosity");
args.Add ("detailed");
nuget.StartInfo.Arguments = StringUtils.FormatArguments (args);
EnviromentManager.SetEnvironmentVariables (nuget);
EnvironmentManager.SetEnvironmentVariables (nuget);
EventLogger.LogEvent (log, "Restoring nugets for {0} ({1}) on path {2}", TestName, Mode, projectPath);

var timeout = TimeSpan.FromMinutes (15);
Expand Down
2 changes: 1 addition & 1 deletion tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/IResourceManager.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ namespace Microsoft.DotNet.XHarness.iOS.Shared.Tasks {

/// <summary>
/// Managed the resorces that can be used by the different tests tasks so that when ran async they do not step
/// on eachother.
/// on each other.
/// </summary>
public interface IResourceManager
{
Expand Down
4 changes: 2 additions & 2 deletions tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/MSBuild.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public MSBuild (Func<string> msbuildPath,
xbuild.StartInfo.FileName = msbuildPath ();
xbuild.StartInfo.Arguments = StringUtils.FormatArguments (GetToolArguments (projectPlatform, projectConfiguration, projectFile, buildLog));
xbuild.StartInfo.WorkingDirectory = Path.GetDirectoryName (projectFile);
EnviromentManager.SetEnvironmentVariables (xbuild);
EnvironmentManager.SetEnvironmentVariables (xbuild);
xbuild.StartInfo.EnvironmentVariables ["MSBuildExtensionsPath"] = null;
EventLogger.LogEvent (buildLog, "Building {0} ({1})", TestName, Mode);
if (!dryRun) {
Expand Down Expand Up @@ -99,7 +99,7 @@ async Task CleanProjectAsync (string project_file, string project_platform, stri
args.Add ("/t:Clean");
xbuild.StartInfo.Arguments = StringUtils.FormatArguments (args);
xbuild.StartInfo.WorkingDirectory = Path.GetDirectoryName (project_file);
EnviromentManager.SetEnvironmentVariables (xbuild);
EnvironmentManager.SetEnvironmentVariables (xbuild);
EventLogger.LogEvent (log, "Cleaning {0} ({1}) - {2}", TestName, Mode, project_file);
var timeout = TimeSpan.FromMinutes (1);
await ProcessManager.RunAsync (xbuild, log, timeout);
Expand Down

9 comments on commit f147fe9

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Pipeline scripts tests failed on VSTS: device tests iOS (DDFun) 🔥

The tests of the scripts used in the pepeline failed. The build was cancelled.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Failed provisioning profiles.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Failed installing dependencies.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Pipeline scripts tests failed on VSTS: device tests tvOS (DDFun) 🔥

The tests of the scripts used in the pepeline failed. The build was cancelled.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (DDFun) 🔥

Failed provisioning profiles.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (DDFun) 🔥

Failed installing dependencies.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests tvOS (Cambridge) ❌

Device tests failed on VSTS: device tests tvOS (Cambridge).

Test results

150 tests' device not found, 0 tests passed.

Pipeline on Agent XI-MANTIS

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests iOS (Cambridge) ❌

Device tests failed on VSTS: device tests iOS (Cambridge).

Test results

2 tests failed, 148 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - device/Release (all optimizations): BuildFailure (Harness exception for 'monotouch-test': System.Exception: Could not find where to add a new DefineConstants node
    at Microsoft.DotNet.XHarness.iOS.Shared.Utilities.ProjectFileExtensions.AddAdditionalDefines (System.Xml.XmlDocument csproj, System.String value, System.String platform, System.String configuration) [0x00160] in /Users/xamarinqa/myagent/_work/6/s/xamarin-macios/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Utilities/ProjectFileExtensions.cs:827
    at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x0039e] in /Users/xamarinqa/myagent/_work/6/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:178
    at Microsoft.DotNet.XHarness.iOS.Shared.Tasks.TestTasks.RunInternalAsync () [0x00117] in /Users/xamarinqa/myagent/_work/6/s/xamarin-macios/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/TestTask.cs:274 )
  • monotouch-test/iOS Unified 64-bits - device/Debug (all optimizations): BuildFailure (Harness exception for 'monotouch-test': System.Exception: Could not find where to add a new DefineConstants node
    at Microsoft.DotNet.XHarness.iOS.Shared.Utilities.ProjectFileExtensions.AddAdditionalDefines (System.Xml.XmlDocument csproj, System.String value, System.String platform, System.String configuration) [0x00160] in /Users/xamarinqa/myagent/_work/6/s/xamarin-macios/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Utilities/ProjectFileExtensions.cs:827
    at Xharness.Jenkins.TestVariationsFactory+<>c__DisplayClass4_2`1[T].b__0 () [0x0039e] in /Users/xamarinqa/myagent/_work/6/s/xamarin-macios/tests/xharness/Jenkins/TestVariationsFactory.cs:178
    at Microsoft.DotNet.XHarness.iOS.Shared.Tasks.TestTasks.RunInternalAsync () [0x00117] in /Users/xamarinqa/myagent/_work/6/s/xamarin-macios/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Tasks/TestTask.cs:274 )

Pipeline on Agent XI-A-Batman

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.11'' 🔥 : hudson.AbortException: Xamarin.Mac tests on macOS 10.11 failed (xammac_tests)

✅ Provisioning succeeded
✅ Build succeeded
✅ Packages built successfully

View packages

✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Xamarin.Mac tests on 10.11 failed: Xamarin.Mac tests on macOS 10.11 failed (xammac_tests) 🔥
✅ Test run succeeded

Please sign in to comment.