Add analyzer for RequiresAssemblyFilesAttribute #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlakollo
reviewed
Jan 5, 2021
agocke
reviewed
Jan 6, 2021
Stop using Linq in HasName
mateoatr
changed the title
tlakollo
reviewed
Jan 9, 2021
test/ILLink.RoslynAnalyzer.Tests/RequiresAssemblyFilesAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
agocke
reviewed
Jan 12, 2021
| internal static bool TryGetRequiresAssemblyFileAttribute (this ISymbol symbol, out AttributeData? attribute) | ||
| { | ||
| attribute = null; | ||
| if (symbol.GetAttributes ().FirstOrDefault (attr => attr.AttributeClass is { } attrClass && |
There was a problem hiding this comment.
The lambda here creates an allocation, and FirstOrDefault requires an additional delegate allocation.
There was a problem hiding this comment.
I removed all Linq usages in this file as well - PTAL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an analyzer for the proposed attribute,
RequiresAssemblyFilesAttribute. Once (if) the attribute is landed in the runtime, the appropriate APIs should be annotated in the runtime libraries and suitable tests should be added in here.