[XAT.Bytecode] Don't mark public Kotlin methods private if they shadow a private property/field #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w a private property/field. [#571]
jonpryor
pushed a commit
that referenced
this pull request
Feb 21, 2020
Fixes: #571 Don't mark `public` Kotlin methods as `private` if they "shadow" -- share the same name as -- a private property or field. If a library uses Kotlin's `NAME_SHADOWING` we incorrectly match the `private` property/field to the `public` method and mark the methods as `private`. Given Kotlin: @Suppress("NAME_SHADOWING") public class NameShadowing { // Property and method private val count: Int = 3 fun count(): Int = count // Field and method private var hitCount = 0 fun hitCount(): Int = hitCount // Property and setter private var type = 0 fun setType(type: Int) = { println (type); } } Then the public methods `NameShadowing.count()`, `NameShadowing.hitCount()`, and `NameShadowing.setType()` were not present within the C# binding. Support name shadowing by only considering `getFoo()` methods as potential property getters, instead of allowing `foo`. (Allowing `foo` was likely incorrect anyways.) Additionally, when considering if a method is a potential property setter, also check that the method's return type is `void`. [Xamarin.Android.Tools.Bytecode] Kotlin name shadowing support (#573)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #571.
If a library uses Kotlin's "Name Shadowing" we incorrectly match the
privateproperty/field to thepublicmethod and mark the methods asprivate.To fix:
getXXXmethods as potential property getters instead of also allowingXXX. (This seems like it was incorrect anyways.)void.