-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate devices listing #337
Conversation
} | ||
else | ||
{ | ||
return FindRepoRoot(new DirectoryInfo(dir).Parent.FullName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FindRepoRoot [](start = 27, length = 12)
should we ensure we are not going outside the repo root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what do you mean.. If we don't find ".git" folder we will return null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless you meant that Parent is null when in root dir - this is now fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have fixed this in 4c506bb :-)
Thanks for adding this! @krwq should we have this automatically run as part of a build so that the list gets updated every PR that is adding a new binding? |
@joperezr we can run this separately and auto create PRs whenever there is any diff if that is easy to add. I was also initially planning to add tiny bit more there but haven't had time (categorization by type of sensor and stuff) |
Improve list of devices and make it so that it is auto-regenerated when
dotnet run
is run on thetools/device-listing
.Currently it is based on the first line of the README.md file in a device description.
Note: markdown does not display custom tags which I use in here and therefore they can be used as a placeholder for where generated content can be.
I.e. this text is in the custom tag which you cannot see (owners of this repo can edit this post to see)