Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate devices listing #337

Merged
merged 3 commits into from
Mar 18, 2019
Merged

Auto-generate devices listing #337

merged 3 commits into from
Mar 18, 2019

Conversation

krwq
Copy link
Member

@krwq krwq commented Mar 17, 2019

Improve list of devices and make it so that it is auto-regenerated when dotnet run is run on the tools/device-listing.

Currently it is based on the first line of the README.md file in a device description.

Note: markdown does not display custom tags which I use in here and therefore they can be used as a placeholder for where generated content can be.

I.e. this text is in the custom tag which you cannot see (owners of this repo can edit this post to see)

@krwq krwq requested a review from tarekgh March 17, 2019 06:08
}
else
{
return FindRepoRoot(new DirectoryInfo(dir).Parent.FullName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FindRepoRoot [](start = 27, length = 12)

should we ensure we are not going outside the repo root?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what do you mean.. If we don't find ".git" folder we will return null

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless you meant that Parent is null when in root dir - this is now fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have fixed this in 4c506bb :-)

@krwq krwq merged commit b7f0358 into dotnet:master Mar 18, 2019
@joperezr
Copy link
Member

Thanks for adding this! @krwq should we have this automatically run as part of a build so that the list gets updated every PR that is adding a new binding?

@krwq
Copy link
Member Author

krwq commented Apr 10, 2019

@joperezr we can run this separately and auto create PRs whenever there is any diff if that is easy to add. I was also initially planning to add tiny bit more there but haven't had time (categorization by type of sensor and stuff)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants