Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out of infinite recursion #2335

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Break out of infinite recursion #2335

merged 1 commit into from
Aug 14, 2024

Conversation

skipfire
Copy link
Contributor

@skipfire skipfire commented Jul 26, 2024

Fixes #2332

Using the Cargo library on a Pi 5 encountered a symbolic link that went to a parent directory creating an infinite loop in the C# code. This change limits the directory depth so that it can break out of the infinite loop when present.

Future major version should be relying on NativeLibrary probing paths as opposed to us doing the probing ourselves as mentioned in #2332 .

Microsoft Reviewers: Open in CodeFlow

@raffaeler
Copy link
Contributor

/azp run dotnet.iot

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krwq
Copy link
Member

krwq commented Aug 8, 2024

[Triage] this is acceptable solution for now but we should create an issue before merging this to make a proper solution using new .NET Core APIs once we drop netstandard2.0 support

@dotnet-policy-service dotnet-policy-service bot added the area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins label Aug 8, 2024
@pgrawehr
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pgrawehr pgrawehr merged commit 5c5d072 into dotnet:main Aug 14, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Device.Gpio Contains types for using general-purpose I/O (GPIO) pins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo causes GpioController to hang on Raspberry Pi 5 Bookworm
4 participants