-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable a flaky test for SysFs #2023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Have we found evidence of runs where ONLY this test fails? What I've seen in the past, is that sometimes a board would end up in a bad state of pinmode on the input pin and it essentially fails around 10 or so tests. If that's the case, then I think that this PR isn't really getting us much value, and it is dropping coverage. My suggestion is wait for a PR to fail the tests and validate that this test is the only one failing, sound good? |
As I already have noted: This statistic shows that this is the only test that failed in all of the recent builds. I've manually checked 2 or 3 recent helix failures, and it was always this test (and only this test). |
This report indicates that this particular test is responsible for most of the helix test failures.
Microsoft Reviewers: Open in CodeFlow