Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove space #1275

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Remove space #1275

merged 3 commits into from
Nov 10, 2020

Conversation

richlander
Copy link
Member

@richlander richlander commented Nov 10, 2020 •
edited
Loading

The build is broken due to #1263. I am using this PR to fix it.

@ghost ghost added the area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio label Nov 10, 2020
@joperezr
Copy link
Member

How could that break the build?

@joperezr
Copy link
Member

Actually I just checked and looks like indeed the build is broken but due to a failed test most likely coming from that PR. This is the console output I'm seeing:

    System.Device.Gpio.Tests.ProtocolsTests.SPI_Mcp3008CanRead [FAIL]
      System.ArgumentOutOfRangeException : Specified argument was out of the range of valid values.
      Parameter name: Unsupported Channel Count
      Stack Trace:
        /_/src/devices/Mcp3xxx/Mcp3xxx.cs(148,0): at Iot.Device.Adc.Mcp3xxx.ReadInternal(Int32 channel, InputType inputType, Int32 adcResolutionBits)
        /_/src/devices/Mcp3xxx/Mcp3xxx.cs(121,0): at Iot.Device.Adc.Mcp3xxx.Read(Int32 channel)
        /_/src/System.Device.Gpio.Tests/ProtocolTests.cs(36,0): at System.Device.Gpio.Tests.ProtocolsTests.SPI_Mcp3008CanRead()

@joperezr
Copy link
Member

Merging to unblock other PRs.

@joperezr joperezr merged commit 084a7d8 into dotnet:master Nov 10, 2020
@richlander richlander deleted the fixbuildbreak branch November 10, 2020 19:36
ZhangGaoxing pushed a commit to ZhangGaoxing/iot that referenced this pull request Mar 15, 2021
@richlander @joperezr @ZhangGaoxing
Remove space (dotnet#1275)
330621a 
* Remove space

* Fix Mcp3xxx switch condition causing the build to break

* Fix other switch statements that were changed incorrectly

Co-authored-by: Jose Perez Rodriguez <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

Assignees
No one assigned
Labels
area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richlander @joperezr