Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FSharp in the VMR for non-source-build #18895

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 6, 2024

@ViktorHofer ViktorHofer changed the title Enable FSharp for non-source-build Enable FSharp in the VMR for non-source-build Mar 6, 2024
@mmitche mmitche marked this pull request as ready for review March 26, 2024 19:11
@mmitche mmitche requested review from a team as code owners March 26, 2024 19:11
@mmitche
Copy link
Member

mmitche commented Mar 26, 2024

Update here:

One issue appears to a be test-build dependency issue. The other appears to be an issue with building with the new SDK.

@mmitche
Copy link
Member

mmitche commented Mar 26, 2024

dotnet/fsharp#16955

@mmitche
Copy link
Member

mmitche commented Mar 26, 2024

There may be one additional issue. I think that the assembly check at the end of the fsharp build is picking up the package cache.

@ViktorHofer ViktorHofer enabled auto-merge (squash) April 2, 2024 09:50
@ViktorHofer ViktorHofer merged commit dc9d9b5 into main Apr 2, 2024
22 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-5 branch April 2, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'fsharp' repo exclusion in non-source build scenario
3 participants