add explicit flags to remove some booleans in the CE typechecker #9975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight cheese-move away from primitive obsession.
Tinkering in the CE typechecking I kept getting mixed up around what the two boolean flags that
tryTrans
takes meant. So I pulled them out into named values and adjusted callsites for clarity.Further documentation on the types could go into why specific flags are chosen.